-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce pnpm lockfile v9 detector #1283
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
======================================
Coverage 89.3% 89.3%
======================================
Files 379 387 +8
Lines 30082 30336 +254
Branches 1840 1863 +23
======================================
+ Hits 26870 27120 +250
- Misses 2821 2822 +1
- Partials 391 394 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
test/Microsoft.ComponentDetection.Detectors.Tests/PnpmParsingUtilitiesTest.cs
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/pnpm/ParsingUtilities/PnpmV9ParsingUtilities.cs
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/pnpm/Pnpm9Detector.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/pnpm/ParsingUtilities/PnpmV9ParsingUtilities.cs
Outdated
Show resolved
Hide resolved
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
There is still no official docs for the new v9 lock if format, so this parsing logic is empirically based and will be updated as specs are released
Issue tracking v9 specs: pnpm/spec#6
Format should eventually get updated here: https://github.com/pnpm/spec/blob/master/lockfile
Includes a small refactoring to re-use code and establish consistency between lockfile parsing.