Strong-name the assemblies #72
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
force-pushed
the
strong-naming
branch
from
d72461f
to
6d37000
Compare
|
@dfederm Are we okay to still merge this, even if we're blocked with upstream dependencies? EDIT: Nope! Moving this to draft for now. |
cobya
added
version:major
status:blocked
|
I opened a PR upstream dotnet/Docker.DotNet#567 |
|
PR merged upstream. Waiting for a release now. |
|
Version |
|
See #453 |
|
@dfederm can you rebase this branch please? I don't have permissions to push to your fork, but I've created a branch you can reset to: We're getting closer, but the build still fails due to a lack of strong named assemblies for Tomlyn and Valleysoft.DockerfileModel. I've created issues upstream: I'll also create pull requests when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strong-names the assemblies so that applications which are themselves strong-named can use these libraries.
The snk file was generated by running:
sn -k StrongName.snk