-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Central Package Management #444
base: main
Are you sure you want to change the base?
Conversation
I am seeing a lot of warnings in the build output, like: |
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<ProjectReference Include="..\..\..\src\DurableTask.Netherite\DurableTask.Netherite.csproj" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The samples were designed to use the published package, not the locally built one. I suppose you are changing this so it works with centralized package management?
I am not sure what the reason was to use the published package. Probably so that the sample runs standalone and users can copy/paste it easily. That will of course no longer work with the centralized package management. But it's probably not a big issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can switch it back definitely. I thought we should make samples built on the latest Netherite and thus use the locally built one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, otherwise LGTM.
This PR moves to Central Package Management
Add Directory.package.props for CPM.
Remove all versions at each csproj