docs(agents): fix new-item-type agent to require command_support.yaml review and prohibit VCR cassette creation - #200
Merged
Alon Yeshurun (ayeshurun) merged 9 commits intoMar 29, 2026
Conversation
This script benchmarks the startup performance of the CLI by measuring module import times, CLI invocation times, and heavy dependency loading. It allows comparisons against a baseline branch or tag.
…all item types, prohibit creating VCR cassettes Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com> Agent-Logs-Url: https://github.com/ayeshurun/fabric-cli/sessions/c94f523e-ee18-4151-9b8f-e8cb2e27e41b
…terns Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com> Agent-Logs-Url: https://github.com/ayeshurun/fabric-cli/sessions/c94f523e-ee18-4151-9b8f-e8cb2e27e41b
shirasassoon
approved these changes
Mar 29, 2026
shirasassoon
approved these changes
Mar 29, 2026
shirasassoon
previously approved these changes
Mar 29, 2026
shirasassoon
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
✨ Description of new changes
PR #85 (SnowflakeDatabase onboarding) exposed two gaps in the
new-item-type.agent.mdinstructions: the agent skippedcommand_support.yamlentirely for simple items, and fabricated 14 VCR cassette recording files.Step 10 (
command_support.yaml)unsupported_itemslists forrm,get,set,mkdir-- applies to all item types, not just those with definitionsStep 11 (test parametrization)
tests/test_commands/recordings/. Only modify parametrization lists inconftest.py. Recordings are generated from live test runs.