Skip to content

fix: Fix codeql suppress comment #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alon Yeshurun (ayeshurun) merged 8 commits into from
Mar 31, 2026
Merged

fix: Fix codeql suppress comment #204

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a9c1621
Add benchmark script for CLI startup performance
ayeshurun Mar 17, 2026
6c7e06e
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
Mar 19, 2026
7a563ff
Delete scripts/benchmark_startup.py
ayeshurun Mar 22, 2026
28ea374
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
Mar 22, 2026
273a7eb
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
Mar 23, 2026
e71de12
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
Mar 25, 2026
e53d848
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
Mar 31, 2026
b9518ea
Fix indentation in SHA-1 fingerprint calculation
ayeshurun Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/fabric_cli/core/fab_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,8 +731,8 @@ def _load_pem_certificate(
)
cert = x509.load_pem_x509_certificate(certificate_data, default_backend())
fingerprint = cert.fingerprint(
hashes.SHA1()
) # CodeQL [SM02167] SHA‑1 thumbprint is only a certificate identifier required by MSAL/Microsoft Entra, not a cryptographic operation
hashes.SHA1() # CodeQL [SM02167] SHA‑1 thumbprint is only a certificate identifier required by MSAL/Microsoft Entra, not a cryptographic operation
)
Comment thread
shirasassoon marked this conversation as resolved.
return self._Cert(certificate_data, private_key, fingerprint)

def _load_pkcs12_certificate(
Expand Down
Loading