Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/fixed-20260415-120000.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: fixed
body: Remove hardcoded "Created by fab" and "Imported from fab" descriptions from mkdir and import commands
time: 2026-04-15T12:00:00.000000000Z
custom:
Author: HasanAboShally
AuthorLink: https://github.com/HasanAboShally
1 change: 0 additions & 1 deletion src/fabric_cli/commands/fs/impor/fab_fs_import_item.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ def _import_create_environment_item(

item_payload: dict = {
"type": str(item.item_type),
"description": "Imported from fab",
"displayName": item.short_name,
"folderId": item.folder_id,
}
Comment thread
HasanAboShally marked this conversation as resolved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ def exec(connection: VirtualWorkspaceItem, args: Namespace) -> None:

# Base payload
payload = {
"description": "Created by fab",
Comment thread
HasanAboShally marked this conversation as resolved.
"displayName": connection.short_name,
"connectivityType": connectivityType,
}
Comment thread
HasanAboShally marked this conversation as resolved.
Expand Down
1 change: 0 additions & 1 deletion src/fabric_cli/commands/fs/mkdir/fab_fs_mkdir_folder.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def exec(folder: Folder, args: Namespace) -> str | None:
utils_ui.print_grey(f"Creating a new Folder...")

payload = {
"description": "Created by fab",
"displayName": foldername,
}
if parent_folder_id:
Expand Down
1 change: 0 additions & 1 deletion src/fabric_cli/commands/fs/mkdir/fab_fs_mkdir_item.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ def exec(item: Item, args: Namespace) -> str | None:
utils.remove_keys_from_dict(params, ["displayname", "type"])

payload = {
"description": "Created by fab",
"displayName": item_name,
"type": str(item_type),
"folderId": item.folder_id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def exec(workspace: Workspace, args: Namespace) -> None:
utils.remove_keys_from_dict(args.params, ["displayName"])
Comment thread
HasanAboShally marked this conversation as resolved.
Outdated

payload = {
"description": "Created by fab",
"displayName": workspace.short_name,
}
payload.update(args.params)
Comment thread
HasanAboShally marked this conversation as resolved.
Outdated
Expand Down
1 change: 0 additions & 1 deletion src/fabric_cli/utils/fab_cmd_import_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def get_payload_for_item_type(
definition = _build_definition(path, input_format)
return {
"type": str(item.item_type),
"description": "Imported from fab",
"folderId": item.folder_id,
"displayName": item.short_name,
"definition": definition,
Expand Down
7 changes: 0 additions & 7 deletions tests/test_core/test_fab_hiearchy.py
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,6 @@ def _mock_build(path, resolved_format=""):

_expected_payload = {
"type": "Notebook",
"description": "Imported from fab",
"displayName": "item_name",
"folderId": None,
"definition": {"format": "ipynb", "parts": _base_payload["parts"]},
Expand All @@ -429,7 +428,6 @@ def _mock_build(path, resolved_format=""):

_expected_payload = {
"type": "SparkJobDefinition",
"description": "Imported from fab",
"displayName": "item_name",
"folderId": None,
"definition": {
Expand All @@ -445,7 +443,6 @@ def _mock_build(path, resolved_format=""):

_expected_payload = {
"type": "SparkJobDefinition",
"description": "Imported from fab",
"displayName": "item_name",
"folderId": None,
"definition": {
Expand All @@ -469,7 +466,6 @@ def _mock_build(path, resolved_format=""):

_expected_payload = {
"type": "Eventhouse",
"description": "Imported from fab",
"displayName": "item_name",
"folderId": None,
"definition": {"parts": _base_payload["parts"]},
Expand All @@ -490,7 +486,6 @@ def _mock_build(path, resolved_format=""):

_expected_payload = {
"type": "Report",
"description": "Imported from fab",
"displayName": "item_name",
"folderId": None,
"definition": {"parts": _base_payload["parts"]},
Expand All @@ -506,7 +501,6 @@ def _mock_build(path, resolved_format=""):

_expected_payload_without_format = {
"type": "SemanticModel",
"description": "Imported from fab",
"displayName": "item_name",
"folderId": None,
"definition": {"parts": _base_payload["parts"]},
Expand All @@ -518,7 +512,6 @@ def _mock_build(path, resolved_format=""):

_expected_payload_with_format = {
"type": "SemanticModel",
"description": "Imported from fab",
"displayName": "item_name",
"folderId": None,
"definition": {
Expand Down
3 changes: 0 additions & 3 deletions tests/test_utils/test_fab_cmd_mkdir_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ def test_fabric_data_pipelines_workspace_identity_no_params_success():
"""Test FabricDataPipelines with WorkspaceIdentity credential type when no parameters are required."""
# Arrange
payload = {
"description": "Created by fab",
"displayName": "test-connection",
"connectivityType": "ShareableCloud"
}
Expand Down Expand Up @@ -63,7 +62,6 @@ def test_connection_with_required_params_missing_failure():
"""Test that connection creation fails when required parameters are missing."""
# Arrange
payload = {
"description": "Created by fab",
"displayName": "test-connection",
"connectivityType": "ShareableCloud"
}
Expand Down Expand Up @@ -107,7 +105,6 @@ def test_workspace_identity_with_unsupported_params_ignored_success():
"""Test that WorkspaceIdentity ignores unsupported credential parameters with warning."""
# Arrange
payload = {
"description": "Created by fab",
"displayName": "test-connection",
"connectivityType": "ShareableCloud"
}
Expand Down
Loading