Skip to content

Private Endpoint Support - #1078

Merged
Brett Wilson (MSBrett) merged 19 commits into
devfrom
msbrett/dev/PrivateNet
Oct 31, 2024
Merged

Private Endpoint Support#1078
Brett Wilson (MSBrett) merged 19 commits into
devfrom
msbrett/dev/PrivateNet

Conversation

@MSBrett

@MSBrett Brett Wilson (MSBrett) commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

🛠️ Description

Private endpoints support.

  • Added private endpoints for storage account & Keyvault.
  • Added managed virtual network & storage endpoint for Azure Data Factory Runtime.
  • All data processing now happens within a vNet.
  • Added param to disable external access to data lake
  • Added param to specify subnet range of vnet - minumum size = /27

📷 Screenshots

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@MSBrett Brett Wilson (MSBrett) added Status: 🔬 Code review Issue is currently in code review with open PRs Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution labels Oct 28, 2024
flanakin
Michael Flanakin (flanakin) approved these changes Oct 29, 2024
View reviewed changes
Comment thread src/templates/finops-hub/main.bicep Outdated
Comment thread src/templates/finops-hub/main.bicep Outdated
Comment thread src/templates/finops-hub/modules/hub.bicep Outdated
Comment thread src/templates/finops-hub/modules/hub.bicep Outdated
Comment thread src/templates/finops-hub/modules/hub.bicep
Comment thread src/templates/finops-hub/modules/storage.bicep
Comment thread src/templates/finops-hub/modules/storage.bicep
Comment thread src/templates/finops-hub/modules/storage.bicep Outdated
Comment thread src/templates/finops-hub/modules/storageEndpoints.bicep Outdated
Comment thread src/templates/finops-hub/modules/vnet.bicep Outdated
@flanakin

Michael Flanakin (flanakin) commented Oct 29, 2024

Copy link
Copy Markdown
Collaborator

Don't forget to update template.md with the added resources.

@MSBrett
Brett Wilson (MSBrett) deleted the msbrett/dev/PrivateNet branch October 31, 2024 17:28
@MSBrett Brett Wilson (MSBrett) changed the title Msbrett/dev/private net Private Endpoint Support Nov 6, 2024
@MSBrett Brett Wilson (MSBrett) linked an issue Nov 6, 2024 that may be closed by this pull request
A non public deployment of FinOps Hub (Use Private Endpoints) #605
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurclares Arthur Clares (arthurclares) Awaiting requested review from arthurclares
@flanakin Michael Flanakin (flanakin) Awaiting requested review from flanakin flanakin is a code owner

Assignees

@flanakin Michael Flanakin (flanakin)

@arthurclares Arthur Clares (arthurclares)

Labels

Needs: Review 👀 PR that is ready to be reviewed Status: 🔬 Code review Issue is currently in code review with open PRs Tool: FinOps hubs Data pipeline solution

Projects

None yet

Milestone

2024-11 - November

Development

Successfully merging this pull request may close these issues.

A non public deployment of FinOps Hub (Use Private Endpoints)

3 participants

@MSBrett @flanakin @arthurclares