Skip to content

Fix bug where x_ResourceType is changed to the wrong value - #1212

Merged
Michael Flanakin (flanakin) merged 3 commits into
devfrom
flanakin/dev/hubs-xrtbug
Dec 22, 2024
Merged

Michael Flanakin (flanakin) merged 3 commits into
devfrom
flanakin/dev/hubs-xrtbug

Conversation

@flanakin

Copy link
Copy Markdown
Collaborator

🛠️ Description

Remove code that was setting the wrong x_ResourceType value

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@flanakin
Michael Flanakin (flanakin) deleted the flanakin/dev/hubs-xrtbug branch December 22, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants