Fix deployment errors in OpenDataFunctions.kql - #1242
Brett Wilson (MSBrett) wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/templates/finops-hub/modules/scripts/IngestionSetup.kql:1253
- The newly introduced ResourceName variable should be covered by tests to ensure its correct behavior.
| extend ResourceName = tostring(tmp_ResourceDetails.ResourceName)
| @@ -6,31 +6,9 @@ | |||
| with (docstring = 'Return details about the specified ID.', folder = 'OpenData') | |||
There was a problem hiding this comment.
My VS code is telling me that it is still 132138 characters. I can't deploy it: Error BCP184: File 'C:\Projects\finops-toolkit\src\templates\finops-hub\modules\scripts\OpenDataFunctions.kql' exceeded maximum size of 131072 characters.
| @@ -6,31 +6,9 @@ | |||
| with (docstring = 'Return details about the specified ID.', folder = 'OpenData') | |||
| resource_type(id: string) { | |||
| dynamic({ | |||
| "arizeai.observabilityeval/organizations": { "SingularDisplayName": "Azure Native ArizeAi Cloud Service" } | |||
There was a problem hiding this comment.
How are you deciding what to keep and what to remove?
Michael Flanakin (flanakin)
left a comment
There was a problem hiding this comment.
I don't love removing values. While I feel there has to be a better solution, I submitted a PR to split the file into multiple files since we know it will grow over time. I don't love it, but it should get us past the current issue. I validated the deployment so it should resolve the current issues. Thanks for digging into this.
|
Closing in favor of #1269 |
🛠️ Description
This PR fixes deployment caused by
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?