Skip to content

Break out bicep modules for hubs extensibility - #1800

Merged
Michael Flanakin (flanakin) merged 14 commits into
devfrom
flanakin/hubs-ext
Oct 11, 2025
Merged

Break out bicep modules for hubs extensibility#1800
Michael Flanakin (flanakin) merged 14 commits into
devfrom
flanakin/hubs-ext

Conversation

@flanakin

@flanakin Michael Flanakin (flanakin) commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator

🛠️ Description

This PR reorganizes FinOps hubs bicep into a cleaner, more extensible structure while fixing build issues and improving maintainability.

  • Moved all JSON schemas into relevant module directories
  • Split large monolithic files (e.g., 5K+ line dataFactory.bicep) into smaller modules
  • Moved all framework modules into the fx folder
  • Organized apps into X.Y/Z folders for each publisher/app:
    • Microsoft.CostManagement/Exports – Cost export functionality
    • Microsoft.CostManagement/ManagedExports – Managed exports
    • Microsoft.FinOpsHubs/Analytics – Data Explorer and analytics
    • Microsoft.FinOpsHubs/Core – Core hub infrastructure
    • Microsoft.FinOpsHubs/RemoteHub – Remote hub functionality
  • Resolved all Bicep compilation errors/warnings
  • Added #disable-next-line BCP318 with explanations for null safety
  • Fixed Build-Toolkit.ps1 param generation bug
  • Updated PowerShell build scripts with correct paths

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Aug 11, 2025
@flanakin
Michael Flanakin (flanakin) marked this pull request as draft August 12, 2025 07:21
@flanakin
Michael Flanakin (flanakin) marked this pull request as ready for review August 12, 2025 10:45
@RolandKrummenacher

Roland Krummenacher (RolandKrummenacher) commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I'm getting an error while deploying from your branch, since I'm using a hub name that is a bit longer:

image

I'm trying to update an existing deployment.

@flanakin

Michael Flanakin (flanakin) commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator Author

Roland Krummenacher (@RolandKrummenacher) Sorry for the delay. I fixed this.

@RolandKrummenacher

Roland Krummenacher (RolandKrummenacher) commented Sep 2, 2025

Copy link
Copy Markdown
Collaborator

Roland Krummenacher (@RolandKrummenacher) Sorry for the delay. I fixed this.

Works now. Thanks.

@MSBrett

Brett Wilson (MSBrett) commented Sep 3, 2025

Copy link
Copy Markdown
Contributor
image Getting a bunch of timing related failures.

@flanakin
Refactor dependencies and improve resource initialization in Bicep te…
9c6c16d 
…mplates
msbrett
Fix ADX cluster name length validation
b4b1b13 
- Add @maxlength(22) to clusterName parameter in Analytics app.bicep
- Implement automatic truncation in deployment script
- Ensure hub names up to 18 chars work (18 + 4 for '-adx' = 22 max)
- Prevent deployment failures for longer hub names
MSBrett
Brett Wilson (MSBrett) approved these changes Oct 1, 2025
View reviewed changes

@MSBrett Brett Wilson (MSBrett) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM - Tested and validated

Deployments tested successfully:

  • ✅ Public networking (eastus2)
  • ✅ Private networking (eastus2)
  • ✅ Long hub names with ADX truncation
  • ✅ Multiple subscriptions

Changes validated:

  • ✅ Modular bicep organization works
  • ✅ ADX cluster name validation fixed (Max Furlong (@maxlength)(22))
  • ✅ Private endpoints correctly configured
  • ✅ Resource creation and networking successful

Note for future optimization:
Multiple StopTriggers deployment scripts (one per module) run sequentially with private endpoints, adding ~1 min overhead per script. Consider consolidating into a single script in a future PR for efficiency.

Commits added:

  • b4b1b13: Fix ADX cluster name length validation

@MSBrett Brett Wilson (MSBrett) removed the Needs: Review 👀 PR that is ready to be reviewed label Oct 1, 2025
@flanakin

Michael Flanakin (flanakin) commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator Author

@microsoft-github-policy-service agree [company="Xerilium"]

@flanakin

Michael Flanakin (flanakin) commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator Author

@microsoft-github-policy-service agree company="Xerilium"

@flanakin
Michael Flanakin (flanakin) merged commit ce22272 into dev Oct 11, 2025
3 of 4 checks passed
@flanakin
Michael Flanakin (flanakin) deleted the flanakin/hubs-ext branch October 11, 2025 03:34
@MSBrett Brett Wilson (MSBrett) mentioned this pull request Oct 11, 2025
Closed
Michael Flanakin (flanakin) added a commit that referenced this pull request Jan 31, 2026
@flanakin msbrett
Break out bicep modules for hubs extensibility (#1800)
5b69853 
Co-authored-by: msbrett <msbrett@users.no-reply.github.com>
@MSBrett Brett Wilson (MSBrett) mentioned this pull request Jun 3, 2026
Closed
This was referenced Aug 13, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MSBrett Brett Wilson (MSBrett) MSBrett approved these changes
@arthurclares Arthur Clares (arthurclares) Awaiting requested review from arthurclares

Assignees

@flanakin Michael Flanakin (flanakin)

@arthurclares Arthur Clares (arthurclares)

Labels

None yet

Projects

None yet

Milestone

2025-08 - August

Development

Successfully merging this pull request may close these issues.

4 participants

@flanakin @RolandKrummenacher @MSBrett @arthurclares