-
Notifications
You must be signed in to change notification settings - Fork 246
Fix opendata-ci auto-commit gap and add ISF/eligibility PowerShell commands #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Michael Flanakin (flanakin)
wants to merge
5
commits into
dev
Choose a base branch
from
flanakin/opendata-ci-untracked-files
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aec0820
Add InstanceSizeFlexibility/CommitmentDiscountEligibility PowerShell β¦
flanakin fb6cdd2
Merge origin/dev into flanakin/opendata-ci-untracked-files
flanakin c46f552
Align with FOCUS spend/usage eligibility swap from #2284, regenerate β¦
flanakin 47fd0b7
Fix trailing whitespace flagged by prettier
flanakin bc713c6
chore: Update ms.date in docs-mslearn files
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
docs-mslearn/toolkit/powershell/data/get-finopscommitmentdiscounteligibility.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| --- | ||
| title: Get-FinOpsCommitmentDiscountEligibility command | ||
| description: Get commitment discount eligibility for a meter using the Get-FinOpsCommitmentDiscountEligibility command in the FinOpsToolkit module. | ||
| author: flanakin | ||
| ms.author: micflan | ||
| ms.date: 09/02/2026 | ||
| ms.topic: reference | ||
| ms.service: finops | ||
| ms.subservice: finops-toolkit | ||
| ms.reviewer: micflan | ||
| #customer intent: As a FinOps user, I want to understand how to use the Get-FinOpsCommitmentDiscountEligibility command in the FinOpsToolkit module. | ||
| --- | ||
|
|
||
| # Get-FinOpsCommitmentDiscountEligibility command | ||
|
|
||
| The **Get-FinOpsCommitmentDiscountEligibility** command returns a pre-computed lookup of which meters are eligible for commitment-based discounts (reservations and savings plans), sourced from the Azure Retail Prices API. | ||
|
|
||
| <br> | ||
|
|
||
| ## Syntax | ||
|
|
||
| ```powershell | ||
| Get-FinOpsCommitmentDiscountEligibility ` | ||
| [[-MeterId] <string>] ` | ||
| [-SpendEligibility <string>] ` | ||
| [-UsageEligibility <string>] | ||
| ``` | ||
|
|
||
| <br> | ||
|
|
||
| ## Parameters | ||
|
|
||
| | Name | Description | | ||
| | ---------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | MeterId | Optional. The meter ID to look up. Accepts wildcards. Default = \* (all). | | ||
| | SpendEligibility | Optional. Filters to meters with the specified savings plan (spend commitment) eligibility. FOCUS classifies a savings plan as a spend commitment because you commit to an amount of money. Expected values: Eligible, Not Eligible. Default = null (all). | | ||
| | UsageEligibility | Optional. Filters to meters with the specified reservation (usage commitment) eligibility. FOCUS classifies a reservation as a usage commitment because you commit to a quantity of usage. Expected values: Eligible, Not Eligible. Default = null (all). | | ||
|
Comment on lines
+36
to
+37
|
||
|
|
||
| <br> | ||
|
|
||
| ## Examples | ||
|
|
||
| The following examples demonstrate how to use the Get-FinOpsCommitmentDiscountEligibility command to retrieve commitment discount eligibility based on different criteria. | ||
|
|
||
| ### Get based on meter ID | ||
|
|
||
| ```powershell | ||
| Get-FinOpsCommitmentDiscountEligibility -MeterId "00003b45-e996-5b04-b673-a2db710f9237" | ||
| ``` | ||
|
|
||
| Returns commitment discount eligibility for the specified meter. | ||
|
|
||
| ### Get meters eligible for reservations | ||
|
|
||
| ```powershell | ||
| Get-FinOpsCommitmentDiscountEligibility -UsageEligibility "Eligible" | ||
| ``` | ||
|
|
||
| Returns all meters eligible for reservations. | ||
|
|
||
| <br> | ||
|
|
||
| ## Give feedback | ||
|
|
||
| Let us know how we're doing with a quick review. We use these reviews to improve and expand FinOps tools and resources. | ||
|
|
||
| <!-- prettier-ignore-start --> | ||
| > [!div class="nextstepaction"] | ||
| > [Give feedback](https://portal.azure.com/#view/HubsExtension/InProductFeedbackBlade/extensionName/FinOpsToolkit/cesQuestion/How%20easy%20or%20hard%20is%20it%20to%20use%20the%20FinOps%20toolkit%20PowerShell%20module%3F/cvaQuestion/How%20valuable%20are%20the%20FinOps%20toolkit%20PowerShell%20module%3F/surveyId/FTK/bladeName/PowerShell/featureName/OpenData.GetCommitmentDiscountEligibility) | ||
| <!-- prettier-ignore-end --> | ||
|
|
||
| If you're looking for something specific, vote for an existing or create a new idea. Share ideas with others to get more votes. We focus on ideas with the most votes. | ||
|
|
||
| <!-- prettier-ignore-start --> | ||
| > [!div class="nextstepaction"] | ||
| > [Vote on or suggest ideas](https://github.com/microsoft/finops-toolkit/issues?q=is%3Aissue%20is%3Aopen%20label%3A%22Tool%3A%20PowerShell%22%20sort%3A"reactions-%2B1-desc") | ||
| <!-- prettier-ignore-end --> | ||
|
|
||
| <br> | ||
|
|
||
| ## Related content | ||
|
|
||
| Related products: | ||
|
|
||
| - [Cost Management](/azure/cost-management-billing/costs/) | ||
| - [Azure Retail Prices API](/rest/api/cost-management/retail-prices/azure-retail-prices) | ||
|
|
||
| Related solutions: | ||
|
|
||
| - [FinOps toolkit Power BI reports](../../power-bi/reports.md) | ||
| - [FinOps hubs](../../hubs/finops-hubs-overview.md) | ||
| - [FinOps toolkit open data](../../open-data.md) | ||
|
|
||
| <br> | ||
92 changes: 92 additions & 0 deletions
92
docs-mslearn/toolkit/powershell/data/get-finopsinstancesizeflexibility.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| --- | ||
| title: Get-FinOpsInstanceSizeFlexibility command | ||
| description: Get the instance size flexibility group and ratio for an ARM SKU using the Get-FinOpsInstanceSizeFlexibility command in the FinOpsToolkit module. | ||
| author: flanakin | ||
| ms.author: micflan | ||
| ms.date: 09/02/2026 | ||
| ms.topic: reference | ||
| ms.service: finops | ||
| ms.subservice: finops-toolkit | ||
| ms.reviewer: micflan | ||
| #customer intent: As a FinOps user, I want to understand how to use the Get-FinOpsInstanceSizeFlexibility command in the FinOpsToolkit module. | ||
| --- | ||
|
|
||
| # Get-FinOpsInstanceSizeFlexibility command | ||
|
|
||
| The **Get-FinOpsInstanceSizeFlexibility** command returns instance size flexibility (ISF) ratios, sourced from the Azure Reservations Catalogs API. ISF lets a reservation apply across multiple SKUs in the same flexibility group, weighted by a ratio. | ||
|
|
||
| <br> | ||
|
|
||
| ## Syntax | ||
|
|
||
| ```powershell | ||
| Get-FinOpsInstanceSizeFlexibility ` | ||
| [[-ArmSkuName] <string>] ` | ||
| [[-InstanceSizeFlexibilityGroup] <string>] | ||
| ``` | ||
|
|
||
| <br> | ||
|
|
||
| ## Parameters | ||
|
|
||
| | Name | Description | | ||
| | ---------------------------- | ------------------------------------------------------------------------------------------------------ | | ||
| | ArmSkuName | Optional. The ARM SKU name to look up. Accepts wildcards. Default = \* (all). | | ||
| | InstanceSizeFlexibilityGroup | Optional. The instance size flexibility group to find SKUs for. Accepts wildcards. Default = \* (all). | | ||
|
|
||
| <br> | ||
|
|
||
| ## Examples | ||
|
|
||
| The following examples demonstrate how to use the Get-FinOpsInstanceSizeFlexibility command to retrieve instance size flexibility data based on different criteria. | ||
|
|
||
| ### Get based on ARM SKU name | ||
|
|
||
| ```powershell | ||
| Get-FinOpsInstanceSizeFlexibility -ArmSkuName "Standard_D4s_v5" | ||
| ``` | ||
|
|
||
| Returns the flexibility group and ratio for the Standard_D4s_v5 SKU. | ||
|
|
||
| ### Get based on flexibility group | ||
|
|
||
| ```powershell | ||
| Get-FinOpsInstanceSizeFlexibility -InstanceSizeFlexibilityGroup "Dsv5 Series" | ||
| ``` | ||
|
|
||
| Returns all SKUs in the Dsv5 Series flexibility group. | ||
|
|
||
| <br> | ||
|
|
||
| ## Give feedback | ||
|
|
||
| Let us know how we're doing with a quick review. We use these reviews to improve and expand FinOps tools and resources. | ||
|
|
||
| <!-- prettier-ignore-start --> | ||
| > [!div class="nextstepaction"] | ||
| > [Give feedback](https://portal.azure.com/#view/HubsExtension/InProductFeedbackBlade/extensionName/FinOpsToolkit/cesQuestion/How%20easy%20or%20hard%20is%20it%20to%20use%20the%20FinOps%20toolkit%20PowerShell%20module%3F/cvaQuestion/How%20valuable%20are%20the%20FinOps%20toolkit%20PowerShell%20module%3F/surveyId/FTK/bladeName/PowerShell/featureName/OpenData.GetInstanceSizeFlexibility) | ||
| <!-- prettier-ignore-end --> | ||
|
|
||
| If you're looking for something specific, vote for an existing or create a new idea. Share ideas with others to get more votes. We focus on ideas with the most votes. | ||
|
|
||
| <!-- prettier-ignore-start --> | ||
| > [!div class="nextstepaction"] | ||
| > [Vote on or suggest ideas](https://github.com/microsoft/finops-toolkit/issues?q=is%3Aissue%20is%3Aopen%20label%3A%22Tool%3A%20PowerShell%22%20sort%3A"reactions-%2B1-desc") | ||
| <!-- prettier-ignore-end --> | ||
|
|
||
| <br> | ||
|
|
||
| ## Related content | ||
|
|
||
| Related products: | ||
|
|
||
| - [Cost Management](/azure/cost-management-billing/costs/) | ||
| - [Instance size flexibility for reservations](/azure/cost-management-billing/reservations/instance-size-flexibility) | ||
|
|
||
| Related solutions: | ||
|
|
||
| - [FinOps toolkit Power BI reports](../../power-bi/reports.md) | ||
| - [FinOps hubs](../../hubs/finops-hubs-overview.md) | ||
| - [FinOps toolkit open data](../../open-data.md) | ||
|
|
||
| <br> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this is the actual gap:
git commit -astages only modifications to already-tracked files, so newly generated open-data files were never committed. Worth noting the failure was silent because a failinggit commitis followed bygit push, which exits 0 β the job stayed green while doing nothing. Might be worth aset -eor an explicit check later, but not in this PR.