Skip to content

fix(ci): stop no-op label events from cancelling PR deployments #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Michael Flanakin (flanakin) wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(ci): stop no-op label events from cancelling PR deployments #2303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ftk-pr-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ env:
AZ_RESOURCES_VERSION: '6.16.2'
AZ_STORAGE_VERSION: '6.2.0'

# Deploy runs for the same PR share one group so a new push cancels the
# in-flight deployment. Label events that are NOT 'Needs: Deployment' are no-ops
# (see the check-options condition below), so they get a unique, throwaway group
# — otherwise an unrelated bot label would cancel a running deployment and leave
# only skipped jobs behind, which reads as "deployment not requested".
concurrency:
group: ftk-pr-${{ github.event.pull_request.number }}
group: "ftk-pr-${{ github.event.pull_request.number }}${{ (github.event_name == 'pull_request_target' && github.event.label.name != 'Needs: Deployment') && format('-noop-{0}', github.run_id) || '' }}"
cancel-in-progress: true

permissions:
Expand Down