Skip to content

[Open Data] Fix ISF ratio scale, region coverage and culture handling, and keep retired-SKU reservations visible #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roland Krummenacher (RolandKrummenacher) wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

[Open Data] Fix ISF ratio scale, region coverage and culture handling, and keep retired-SKU reservations visible #2308

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c7905ae
fix(open-data): restore retired SKUs and reconcile ISF ratio scale
Sep 8, 2026
d886805
chore: Update ms.date in docs-mslearn files
github-actions[bot] Sep 8, 2026
3c28f86
docs(open-data): correct the description of the Catalogs API ratio scale
Sep 8, 2026
77949cd
Merge ms.date bot commit into RolandKrummenacher/isf-legacy-floor
Sep 8, 2026
4592311
fix(open-data): parse and write ISF ratios with the invariant culture
Sep 8, 2026
69a1143
refactor(open-data): drop the ISF legacy backfill, keep the generator…
Sep 9, 2026
26bd5f7
chore: Update ms.date in docs-mslearn files
github-actions[bot] Sep 9, 2026
96bf14d
fix(aoe): keep reservations visible when their SKU has no ISF ratio
Sep 9, 2026
8b17917
Merge ms.date bot commit into RolandKrummenacher/isf-legacy-floor
Sep 9, 2026
a8bb300
fix(open-data): normalize ISF ratios so each group starts at 1
Sep 9, 2026
6fcf79f
fix(aoe): guard the remaining ISF joins and scope the fallback to ISF…
Sep 11, 2026
d4b8e31
Merge origin/dev into RolandKrummenacher/isf-legacy-floor
Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion docs-mslearn/toolkit/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: FinOps toolkit changelog
description: Review the latest features and enhancements in the FinOps toolkit, including updates to FinOps hubs, Power BI reports, and more.
author: MSBrett
ms.author: brettwil
ms.date: 09/07/2026
ms.date: 09/09/2026
ms.topic: reference
ms.service: finops
ms.subservice: finops-toolkit
Expand Down Expand Up @@ -60,6 +60,9 @@ The following section lists features and enhancements that are currently in deve

### [Optimization Engine](optimization-engine/overview.md)

- **Fixed**
Comment thread
RolandKrummenacher marked this conversation as resolved.
Outdated
- Fixed reservations disappearing from the reservation workbooks when their SKU is no longer sold. The instance size flexibility joins required a match, so an active reservation on a retired size was dropped from the report entirely rather than shown with its utilization ([#2300](https://github.com/microsoft/finops-toolkit/issues/2300)).

- **Added**
- Added a comprehensive [Azure Optimization Engine reference](optimization-engine/reference.md) for runbooks, schedules, variables, Log Analytics tables, and SQL Database tables ([#1271](https://github.com/microsoft/finops-toolkit/issues/1271)).
- **Changed**
Expand All @@ -78,6 +81,11 @@ The following section lists features and enhancements that are currently in deve

- **Added**
- Added a new [Instance size flexibility](open-data.md#instance-size-flexibility) dataset that maps each ARM SKU to its instance size flexibility group and ratio, sourced from the Azure Reservations Catalogs API. It replaces the deprecated ISF ratio files hosted on `ccmstorageprod.blob.core.windows.net` ([#2090](https://github.com/microsoft/finops-toolkit/issues/2090)).
- **Fixed**
- Fixed the instance size flexibility generator sweeping a hardcoded list of 26 regions, which omitted SKUs that launch in only a handful of regions. It now enumerates every physical region from the ARM locations API, 63 at the time of the change ([#2300](https://github.com/microsoft/finops-toolkit/issues/2300)).
- Fixed ratios being parsed and written with the current culture. On a comma-decimal machine `2.1` was read as `21` or rejected, and written back as `2,1`, which would break every consumer of the file ([#2308](https://github.com/microsoft/finops-toolkit/pull/2308)).
- Fixed the dataset publishing unnormalized ratios. The Catalogs API leaves them unnormalized, so a group's smallest SKU is usually not `1`, while the retired ratio file it replaced was normalized and the Optimization Engine converts quantities into units of a group's smallest SKU. Absolute quantities in the reservation workbooks were inflated by a per-group constant as a result. Each group is now normalized, matching the retired file for 1,223 of the 1,291 rows they share ([#2309](https://github.com/microsoft/finops-toolkit/issues/2309)).
- Fixed the dataset publishing a SKU whose ratio is `0`, which the Optimization Engine's benefits simulation divides by. Non-positive ratios are now dropped ([#2308](https://github.com/microsoft/finops-toolkit/pull/2308)).
Comment thread
RolandKrummenacher marked this conversation as resolved.
Outdated

**[Commitment discount eligibility](open-data.md#commitment-discount-eligibility)**

Expand Down
6 changes: 3 additions & 3 deletions docs-mslearn/toolkit/open-data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Use open data to normalize and enhance your FinOps reporting, ensur
ms.topic: concept-article
author: flanakin
ms.author: micflan
ms.date: 09/01/2026
ms.date: 09/09/2026
ms.service: finops
ms.subservice: finops-toolkit
ms.reviewer: micflan
Expand Down Expand Up @@ -193,9 +193,9 @@ Sample data:

A few important notes about the data:

- It covers Virtual Machines, Redis Cache, and Dedicated Host.
- It covers Virtual Machines, Redis Cache, and Dedicated Host across every physical Azure region.
Comment thread
RolandKrummenacher marked this conversation as resolved.
- `ArmSkuName` is unique across the file and can be used as a join key on its own.
- Ratios are the raw Microsoft values within each group (the smallest SKU isn't always `1`).
- Ratios are normalized so the smallest SKU in each flexibility group has a ratio of `1`. Compare ratios only within a flexibility group.

@helderpinto Hélder Pinto (helderpinto) Sep 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether generating a CSV whose ISF ratios are inconsistent with what Cost Management exports report in the RINormalizationRatio property of the AdditionalInfo column is a good idea.

@helderpinto Hélder Pinto (helderpinto) Sep 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing the full picture, but once I address #2309 I'll have a better idea.

- Data is updated weekly via a GitHub Actions workflow and always reflects the current API catalog, so retired SKUs are removed automatically.

<!-- prettier-ignore-start -->
Expand Down
Loading