-
Notifications
You must be signed in to change notification settings - Fork 247
[Open Data] Fix ISF ratio scale, region coverage and culture handling, and keep retired-SKU reservations visible #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Roland Krummenacher (RolandKrummenacher)
wants to merge
12
commits into
dev
Choose a base branch
from
RolandKrummenacher/isf-legacy-floor
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c7905ae
fix(open-data): restore retired SKUs and reconcile ISF ratio scale
d886805
chore: Update ms.date in docs-mslearn files
github-actions[bot] 3c28f86
docs(open-data): correct the description of the Catalogs API ratio scale
77949cd
Merge ms.date bot commit into RolandKrummenacher/isf-legacy-floor
4592311
fix(open-data): parse and write ISF ratios with the invariant culture
69a1143
refactor(open-data): drop the ISF legacy backfill, keep the generator…
26bd5f7
chore: Update ms.date in docs-mslearn files
github-actions[bot] 96bf14d
fix(aoe): keep reservations visible when their SKU has no ISF ratio
8b17917
Merge ms.date bot commit into RolandKrummenacher/isf-legacy-floor
a8bb300
fix(open-data): normalize ISF ratios so each group starts at 1
6fcf79f
fix(aoe): guard the remaining ISF joins and scope the fallback to ISF…
d4b8e31
Merge origin/dev into RolandKrummenacher/isf-legacy-floor
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.