Allow passing in an existing Key Vault instance - #573
Closed
Michael Flanakin (flanakin) wants to merge 2 commits into
Closed
Allow passing in an existing Key Vault instance#573Michael Flanakin (flanakin) wants to merge 2 commits into
Michael Flanakin (flanakin) wants to merge 2 commits into
Conversation
Michael Flanakin (flanakin)
requested review from
Brett Wilson (MSBrett) and
Anthony Romano (aromano2)
as code owners
February 3, 2024 21:37
Michael Flanakin (flanakin)
requested a review
from Mubarak Tanseer (mutansee)
February 5, 2024 06:26
Michael Flanakin (flanakin)
force-pushed
the
flanakin/dev/byo-keyvault
branch
from
February 5, 2024 10:24
9ed03f9 to
5a4aa4a
Compare
|
Can we include additional parameter to refer a Key/secret/certificate from the Key Vault ? |
Michael Flanakin (flanakin)
force-pushed
the
dev
branch
from
June 24, 2024 06:03
8865b62 to
1e9ce50
Compare
microsoft-github-policy-service
Bot
requested a review
from Arthur Clares (arthurclares)
July 27, 2024 03:27
Collaborator
Author
Mubarak Tanseer (@mutansee) I totally missed this comment. Can you clarify what you're asking for? Are you wanting to be able to create a new secret in the vault? I would rather not bring in something unrelated to hubs. That can always be deployed in a parent template to extend what we have. |
Contributor
|
Not approved. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Allow reusing a Key Vault instance in hubs
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?