Skip to content

Allow passing in an existing Key Vault instance - #573

Closed
Michael Flanakin (flanakin) wants to merge 2 commits into
devfrom
flanakin/dev/byo-keyvault
Closed

Allow passing in an existing Key Vault instance#573
Michael Flanakin (flanakin) wants to merge 2 commits into
devfrom
flanakin/dev/byo-keyvault

Conversation

@flanakin

@flanakin Michael Flanakin (flanakin) commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

🛠️ Description

Allow reusing a Key Vault instance in hubs

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@mutansee

Copy link
Copy Markdown

Can we include additional parameter to refer a Key/secret/certificate from the Key Vault ?

@flanakin

Copy link
Copy Markdown
Collaborator Author

Can we include additional parameter to refer a Key/secret/certificate from the Key Vault ?

Mubarak Tanseer (@mutansee) I totally missed this comment. Can you clarify what you're asking for? Are you wanting to be able to create a new secret in the vault?

I would rather not bring in something unrelated to hubs. That can always be deployed in a parent template to extend what we have.

@MSBrett

Copy link
Copy Markdown
Contributor

Not approved. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants