- Fix cherry pick errors

- Update WhatsNew
microsoft · Feb 6, 2024 · 9dc4edb · 9dc4edb
1 parent 639ad8f
commit 9dc4edb
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 10 deletions.
diff --git a/WHATSNEW.md b/WHATSNEW.md
@@ -1,4 +1,12 @@
-## V3.5.4
+## V3.5.5
+1447
+1424
+1425
+1462
+1464
+1449
+
+## V3.5.4
 - Issue [#1417](https://github.com/microsoft/fluentui-blazor/issues/1417): Fix Autocomplete Enter key in EditForm
 - Issue [#1414](https://github.com/microsoft/fluentui-blazor/issues/1414): NavMenu / KeyCode optimizations
 - Issue [#1413](https://github.com/microsoft/fluentui-blazor/issues/1413): Add TooltipService.Refresh method

diff --git a/examples/Demo/Shared/Microsoft.Fast.Components.FluentUI.xml b/examples/Demo/Shared/Microsoft.Fast.Components.FluentUI.xml
@@ -93,6 +93,53 @@
             <param name="targetId"></param>
             <returns></returns>
         </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.Location">
+            <summary>
+            Gets an <see cref="T:Microsoft.Fast.Components.FluentUI.KeyLocation" /> representing the location of the key on the keyboard or other input device.
+            <see href="https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/location"/>
+            </summary>
+        </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.Key">
+            <summary>
+            Gets the <see cref="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.KeyCode"/> equivalent value.
+            </summary>
+        </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.KeyCode">
+            <summary>
+            Gets the system- and implementation-dependent numerical code identifying the unmodified value of the pressed key.
+            <see href="https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode"/>
+            </summary>
+        </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.Value">
+            <summary>
+            Gets the value of the key pressed by the user
+            </summary>
+        </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.CtrlKey">
+            <summary>
+            Gets a boolean value that indicates if the Control key was pressed
+            </summary>
+        </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.ShiftKey">
+            <summary>
+            Gets a boolean value that indicates if the Shift key was pressed
+            </summary>
+        </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.AltKey">
+            <summary>
+            Gets a boolean value that indicates if the Alt key was pressed
+            </summary>
+        </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.MetaKey">
+            <summary>
+            Gets a boolean value that indicates if the Meta key was pressed
+            </summary>
+        </member>
+        <member name="P:Microsoft.Fast.Components.FluentUI.FluentKeyCodeEventArgs.TargetId">
+            <summary>
+            Gets the identifier of the targeted DOM element.
+            </summary>
+        </member>
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentAccordion.ExpandMode">
             <summary>
             Controls the expand mode of the Accordion, either allowing
@@ -292,7 +339,7 @@
         </member>
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentAnchor.Target">
             <summary>
-            The target attribute specifies where to open the link, if Href is specified. 
+            Gets or sets the target attribute that specifies where to open the link, if Href is specified.
             Possible values: _blank | _self | _parent | _top.
             </summary>
         </member>
@@ -1371,7 +1418,7 @@
         </member>
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentDataGrid`1.NoTabbing">
             <summary>
-            Gets or sets a value indicating whether the component will not add itself to the tab queue. 
+            Gets or sets a value indicating whether the component will not add itself to the tab queue.
             Default is false.
             </summary>
         </member>
@@ -1398,12 +1445,12 @@
         </member>
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentDataGrid`1.RowClass">
             <summary>
-            Optionally defines a class to be applied to a rendered row. 
+            Optionally defines a class to be applied to a rendered row.
             </summary>
         </member>
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentDataGrid`1.RowStyle">
             <summary>
-            Optionally defines a style to be applied to a rendered row. 
+            Optionally defines a style to be applied to a rendered row.
             Do not use to dynamically update a row style after rendering as this will interfere with the script that use this attribute. Use <see cref="P:Microsoft.Fast.Components.FluentUI.FluentDataGrid`1.RowClass"/> instead.
             </summary>
         </member>
@@ -1496,12 +1543,12 @@
         </member>
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentDataGridRow`1.GridTemplateColumns">
             <summary>
-            String that gets applied to the css gridTemplateColumns attribute for the row
+            Gets or sets the string that gets applied to the css gridTemplateColumns attribute for the row.
             </summary>
         </member>
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentDataGridRow`1.RowType">
             <summary>
-            Gets or sets the type of row. See <see cref="T:Microsoft.Fast.Components.FluentUI.DataGridRowType"/>
+            Gets or sets the type of row. See <see cref="T:Microsoft.Fast.Components.FluentUI.DataGridRowType"/>.
             </summary>
         </member>
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentDataGridRow`1.ChildContent">
@@ -4533,7 +4580,7 @@
         <member name="P:Microsoft.Fast.Components.FluentUI.FluentMessageBar.ShowSecondaryAction">
             <summary />
         </member>
-        <member name="M:Microsoft.Fast.Components.FluentUI.FluentMessageBar.LinkClickedAsync(Microsoft.AspNetCore.Components.Web.MouseEventArgs)">
+        <member name="M:Microsoft.Fast.Components.FluentUI.FluentMessageBar.LinkClickedAsync">
             <summary />
         </member>
         <member name="M:Microsoft.Fast.Components.FluentUI.FluentMessageBar.PrimaryActionClickedAsync(Microsoft.AspNetCore.Components.Web.MouseEventArgs)">

diff --git a/src/Core/Components/DataGrid/FluentDataGrid.razor.cs b/src/Core/Components/DataGrid/FluentDataGrid.razor.cs
@@ -377,7 +377,7 @@ private async Task RefreshDataCoreAsync()
     }
 
     // Gets called both by RefreshDataCoreAsync and directly by the Virtualize child component during scrolling
-    private async ValueTask<ItemsProviderResult<(int, TGridItem)>> ProvideVirtualizedItems(ItemsProviderRequest request)
+    private async ValueTask<ItemsProviderResult<(int, TGridItem)>> ProvideVirtualizedItemsAsync(ItemsProviderRequest request)
     {
         _lastRefreshedPaginationStateHash = Pagination?.GetHashCode();
 
@@ -516,7 +516,7 @@ private void CloseColumnOptions()
         StateHasChanged();
     }
 
-    private async Task HandleOnRowFocus(DataGridRowFocusEventArgs args)
+    private async Task HandleOnRowFocusAsync(DataGridRowFocusEventArgs args)
     {
         string? rowId = args.RowId;
         if (_internalGridContext.Rows.TryGetValue(rowId!, out FluentDataGridRow<TGridItem>? row))