fix: implement stable chunking to prevent bundle size regressions (#881) #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gressions - Replace sequential icon chunking with hash-based stable chunking - Prevents existing icons from moving between chunks when new icons are added - Resolves webpack SplitChunksPlugin bundle size regressions - Maintains backward compatibility with existing build process - Ensures even distribution across chunks while maintaining stability Fixes microsoft#881
Author
|
@microsoft-github-policy-service agree
@microsoft-github-policy-service agree |
Contributor
|
Appreciate the help @Niraj-There ! We will be moving forward with this one as there are more changes necessary and we need to expedite delivery. thanks for understanding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #881 - Bundle size regressions when adding new icons
Problem
The original sequential chunking strategy caused existing icons to move between chunks when new icons were added alphabetically, triggering webpack's SplitChunksPlugin to reshuffle chunks and cause bundle size regressions.
Solution
Implemented a stable hash-based chunking strategy that:
Testing
Impact
This enables Teams and other products to safely bump @fluentui/react-icons without triggering webpack bundle size gates.