-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(react-utilities): removes HTMLDialogElement from isHTMLElement… #27958
Closed
bsunderhus
wants to merge
1
commit into
microsoft:master
from
bsunderhus:react-utilities/bugfix--27951
Closed
bugfix(react-utilities): removes HTMLDialogElement from isHTMLElement… #27958
bsunderhus
wants to merge
1
commit into
microsoft:master
from
bsunderhus:react-utilities/bugfix--27951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
InfoButton | mount | 7 | 18 | 5000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 581 | 586 | 5000 | |
Button | mount | 296 | 307 | 5000 | |
Field | mount | 965 | 1017 | 5000 | |
FluentProvider | mount | 647 | 653 | 5000 | |
FluentProviderWithTheme | mount | 80 | 79 | 10 | |
FluentProviderWithTheme | virtual-rerender | 70 | 59 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 81 | 10 | |
InfoButton | mount | 7 | 18 | 5000 | Possible regression |
MakeStyles | mount | 829 | 860 | 50000 | |
Persona | mount | 1648 | 1551 | 5000 | |
SpinButton | mount | 1263 | 1253 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ab53a4c86a49a4d4268f3d87809bee263f818c5d (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f923034:
|
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
I'll close this in favour of #27936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Follow up on #27951
New Behavior
HTMLDialogElement
from union of possible element types to be supported byisHTMLElement
methodRelated Issue(s)
react-utilities
ships incompatible types for TS version 4.4 - 4.6 #27951