Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(react-utilities): removes HTMLDialogElement from isHTMLElement… #27958

Closed

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented May 23, 2023

Previous Behavior

Follow up on #27951

New Behavior

  1. removes HTMLDialogElement from union of possible element types to be supported by isHTMLElement method

Related Issue(s)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 7 18 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 581 586 5000
Button mount 296 307 5000
Field mount 965 1017 5000
FluentProvider mount 647 653 5000
FluentProviderWithTheme mount 80 79 10
FluentProviderWithTheme virtual-rerender 70 59 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 81 10
InfoButton mount 7 18 5000 Possible regression
MakeStyles mount 829 860 50000
Persona mount 1648 1551 5000
SpinButton mount 1263 1253 5000

@size-auditor
Copy link

size-auditor bot commented May 23, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ab53a4c86a49a4d4268f3d87809bee263f818c5d (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f923034:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
560 B
352 B
react-accordion
Accordion (including children components)
88.329 kB
26.706 kB
react-alert
Alert
93.534 kB
22.497 kB
react-avatar
Avatar
57.754 kB
15.041 kB
react-avatar
AvatarGroup
15.632 kB
6.258 kB
react-avatar
AvatarGroupItem
73.968 kB
19.552 kB
react-badge
Badge
23.512 kB
7.197 kB
react-badge
CounterBadge
24.416 kB
7.506 kB
react-badge
PresenceBadge
32.094 kB
8.367 kB
react-button
Button
36.724 kB
9.458 kB
react-button
CompoundButton
43.873 kB
10.939 kB
react-button
MenuButton
41.411 kB
10.791 kB
react-button
SplitButton
49.635 kB
12.364 kB
react-button
ToggleButton
54.866 kB
11.367 kB
react-card
Card - All
88.428 kB
25.004 kB
react-card
Card
83.363 kB
23.556 kB
react-card
CardFooter
9.158 kB
3.844 kB
react-card
CardHeader
11.048 kB
4.538 kB
react-card
CardPreview
9.963 kB
4.192 kB
react-checkbox
Checkbox
34.268 kB
10.793 kB
react-combobox
Combobox (including child components)
87.251 kB
28.1 kB
react-combobox
Dropdown (including child components)
85.635 kB
27.697 kB
react-components
react-components: Button, FluentProvider & webLightTheme
64.855 kB
17.852 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
205.944 kB
57.706 kB
react-components
react-components: FluentProvider & webLightTheme
36.086 kB
11.9 kB
react-datepicker-compat
DatePicker Compat
222.161 kB
59.087 kB
react-dialog
Dialog (including children components)
91.892 kB
27.42 kB
react-divider
Divider
17.399 kB
6.298 kB
react-field
Field
18.864 kB
7.004 kB
react-image
Image
11.479 kB
4.573 kB
react-infobutton
InfoButton
129.685 kB
39.584 kB
react-infobutton
InfoLabel
133.154 kB
40.672 kB
react-input
Input
24.024 kB
7.682 kB
react-label
Label
10.104 kB
4.185 kB
react-link
Link
12.304 kB
5.061 kB
react-menu
Menu (including children components)
130.392 kB
39.788 kB
react-menu
Menu (including selectable components)
133.376 kB
40.307 kB
react-overflow
hooks only
11.214 kB
4.271 kB
react-persona
Persona
64.675 kB
16.968 kB
react-popover
Popover
116.676 kB
35.957 kB
react-portal
Portal
11.649 kB
4.262 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.186 kB
react-positioning
usePositioning
24.008 kB
8.798 kB
react-progress
ProgressBar
13.856 kB
5.434 kB
react-provider
FluentProvider
18.033 kB
6.666 kB
react-radio
Radio
27.282 kB
8.661 kB
react-radio
RadioGroup
11.312 kB
4.71 kB
react-select
Select
25.357 kB
8.798 kB
react-slider
Slider
34.164 kB
11.024 kB
react-spinbutton
SpinButton
33.934 kB
10.328 kB
react-spinner
Spinner
20.882 kB
6.798 kB
react-switch
Switch
29.806 kB
9.274 kB
react-table
DataGrid
149.721 kB
41.154 kB
react-table
Table (Primitives only)
44.348 kB
12.347 kB
react-table
Table as DataGrid
132.279 kB
33.668 kB
react-table
Table (Selection only)
78.056 kB
19.084 kB
react-table
Table (Sort only)
77.386 kB
18.896 kB
react-tags
Tag
21.99 kB
7.887 kB
react-text
Text - Default
12.492 kB
4.92 kB
react-text
Text - Wrappers
15.624 kB
5.232 kB
react-textarea
Textarea
27.528 kB
9.051 kB
react-tooltip
Tooltip
46.708 kB
16.376 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against ab53a4c86a49a4d4268f3d87809bee263f818c5d

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus
Copy link
Contributor Author

I'll close this in favour of #27936

@bsunderhus bsunderhus closed this May 23, 2023
@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: react-utilities ships incompatible types for TS version 4.4 - 4.6
3 participants