refactor: reorganize folder structure of React 18 tests for v9 #34051
+155
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
mainframev
reviewed
Mar 22, 2025
| @@ -1,17 +1,18 @@ | |||
| import * as React from 'react'; | |||
| import { mount } from '@cypress/react'; | |||
There was a problem hiding this comment.
Are we actually testing with a version of Cypress that supports React 18? If not, it seems like the cypress mount might not be using createRoot from the React 18 react-dom/client API.
Currently, we have cypress/[email protected] in the root and we're still using [email protected], which, as I see also inside using cypress/react that does not support 18.
From migration docs of cypress 14:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't add anything new and noteworthy, but rather reorganize the files and folders for upcoming tests that will be added for the components that are not yet covered here.
Previous Behavior
Test files were organized in a flat structure
New Behavior
Move the test files to dedicated folders per component and utils