I need a title #344
Merged
I need a title #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the timestamp is missing
Fixes DateTimeStamp
…ertain conditions
dsgrieve
requested changes
Mar 25, 2024
| } | ||
|
|
||
| public void count(CMSRemark event) { | ||
| System.out.println(event.toString()); |
There was a problem hiding this comment.
not quite yet... I'd say depreciated for now.
There was a problem hiding this comment.
I take that last comment back as this integration test is being used by the GenerationalHeapParser testing
|
|
||
| machine.getAggregation(CMSCycleAggregation.class).ifPresent(cmsCycleCounts -> { | ||
| Assertions.assertEquals( 1, cmsCycleCounts.getInitialMark(), "Initial Mark events count"); | ||
| //Assertions.assertEquals( 1, cmsCycleCounts.getRemark(), "Remark events count"); |
There was a problem hiding this comment.
Are these commented out because they don't give the expected result?
dsgrieve
approved these changes
Mar 27, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more debugging and more tests