Skip to content

fix(build): source plugin metadata from repository root #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bill Berry (WilliamBerryiii) merged 3 commits into from
Aug 19, 2026
Merged

fix(build): source plugin metadata from repository root #2736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b8b60a
fix(build): source plugin metadata from repository root
katriendg Aug 19, 2026
0bedca1
fix(docs): correct relative source reference in marketplace.json desc…
katriendg Aug 19, 2026
e3e7900
test(plugins): add tests for invalid root metadata and missing hooks …
katriendg Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ The project is organized into these main areas:
* Hooks (`.github/hooks/{package-id}/`) - Package-scoped Copilot hook manifests (JSON) that wire lifecycle event commands.
* Extension (`extension/`) - VS Code extension source and packaging.
* GitHub Configuration (`.github/`) - Workflows, instructions, prompts, agents, composite actions, and issue templates, typically organized into `{package-id}` subdirectories.
* Plugin manifest (`.github/plugin.json`) - Deterministic membership and metadata for the sole `hve-core` plugin.
* Plugin manifest (`plugin.json`) - Deterministic membership and metadata for the sole `hve-core` plugin.
* Plugin locator (`.github/plugin/marketplace.json`) - One relative marketplace entry that points to `.github`.
* Logs (`logs/`) - Output from validation and analysis scripts.

Expand Down Expand Up @@ -141,9 +141,9 @@ Parent agents reference subagents using glob paths like `.github/agents/**/code-

The plugin manifest owns plugin and VSIX composition:

* `.github/plugin.json` owns the complete `hve-core` component membership: package-scoped agents, prompts, instructions, and distributable skills discovered from tracked `.github` paths, plus the fixed telemetry hook. `.github/plugin/marketplace.json` contains one relative locator to `.github` and no component recipe.
* Root `plugin.json` owns the complete `hve-core` component membership: package-scoped agents, prompts, instructions, and distributable skills discovered from tracked `.github` paths, plus the fixed telemetry hook. `.github/plugin/marketplace.json` contains one relative locator to the repository root and no component recipe.
* After adding, changing, moving, or removing a distributable artifact, run `npm run plugin:sync` to update the manifest. Run `npm run plugin:validate` to check manifest drift, marketplace parity and containment, component coverage, and hooks.
* The installable plugin root is `.github`; do not materialize a copied plugin tree or create a repository-root `plugins/` directory.
* The installable plugin root is the repository root. Artifact discovery remains limited to package-scoped `.github` paths; do not materialize a copied plugin tree or create a repository-root `plugins/` directory.
* Run `npm run extension:prepare` or `npm run extension:prepare:prerelease` to refresh the single `extension/package.json` and `extension/README.md`. Stable and PreRelease contain the same component set.
* After adding, changing, moving, or removing a documentable agent, prompt, instruction, or skill, run `npm run docs:generate` and commit the matching page under `docs/reference/`. The generator owns page frontmatter and the prefix through `<!-- END AUTO-GENERATED: overview -->`; edit only the preserved `When to use it`, applicable `How to use it`, and `Example usage` tail. Do not edit generated regions or catalog indexes by hand.
* Run `npm run plugin:validate` to confirm the manifest, one-entry locator, component coverage, and hooks are correct.
Expand All @@ -155,7 +155,7 @@ The plugin manifest owns plugin and VSIX composition:
* Scripts follow instructions provided by the codebase for convention and standards.
* Scripts used by the codebase have an `npm run` script for ease of use.
* A root `plugins/` directory is forbidden as validation or package output. Do not create, edit, or stage one.
* The plugin uses `.github` directly. Synchronize `.github/plugin.json`; do not generate plugin output or ZIP packages.
* The plugin uses the repository root directly. Synchronize root `plugin.json`; do not generate plugin output or ZIP packages.
* Artifacts at the root of `.github/agents/`, `.github/instructions/`, `.github/prompts/`, or `.github/skills/` (without a package subdirectory) are repo-specific and excluded from plugin membership and extension packaging. Validation enforces this rule.

PowerShell scripts follow PSScriptAnalyzer rules from `scripts/linting/PSScriptAnalyzer.psd1` and include proper comment-based help. Validation runs via `npm run lint:ps` with results output to `logs/`.
Expand Down
44 changes: 22 additions & 22 deletions .github/hooks/shared/telemetry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,88 +5,88 @@
"sessionStart": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"userPromptSubmitted": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"userPromptSubmit": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"preToolUse": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"postToolUse": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"subagentStart": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"subagentStop": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"sessionEnd": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"stop": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"agentStop": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
],
"preCompact": [
{
"type": "command",
"bash": "${CLAUDE_PLUGIN_ROOT:-.github}/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.github' : $env:CLAUDE_PLUGIN_ROOT) 'hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"bash": "${CLAUDE_PLUGIN_ROOT:-.}/.github/hooks/shared/telemetry/telemetry-collector.sh",
"powershell": "& (Join-Path ([string]::IsNullOrWhiteSpace($env:CLAUDE_PLUGIN_ROOT) ? '.' : $env:CLAUDE_PLUGIN_ROOT) '.github/hooks/shared/telemetry/Invoke-TelemetryCollector.ps1')",
"timeoutSec": 10
}
]
Expand Down
2 changes: 1 addition & 1 deletion .github/instructions/pull-request.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Priority rules:

Skip this section when no GHCP artifact files (`.instructions.md`, `.prompt.md`, `.agent.md`, `SKILL.md`) are included in the changes.

Determine distributable membership from `.github/plugin.json` and the sync policy:
Determine distributable membership from root `plugin.json` and the sync policy:

1. Agents, prompts, and instructions are distributable when they are tracked beneath a package subdirectory and match their canonical suffix.
2. Skills are distributable when a tracked `.github/skills/<package>/<skill>/SKILL.md` exists and its top-level license has no noncommercial qualifier.
Expand Down
Loading
Loading