Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on promises 1.2 #121

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Depend on promises 1.2 #121

merged 1 commit into from
Jan 10, 2024

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Jan 9, 2024

  • Locks promises dependency to 1.2.0 while allowing patch updates.
  • Temporary fix since generics were reverted in the promises package in version 1.3

@SilasKenneth
Copy link
Member

Looks like a good temporary fix. We should just investigate how this could impact devs taking a dependency on httplug, too.

@Ndiritu
Copy link
Contributor Author

Ndiritu commented Jan 9, 2024

Looks like a good temporary fix. We should just investigate how this could impact devs taking a dependency on httplug, too.

Good point.

HTTPlug's latest release requires the Promises lib at a minimum of v1.1 so I think this should be good.

Promises 1.3 reverts the package's state to what it was in 1.1. We released this package with a hard dependency on 1.2 at minimum so any customers using this package already have a setup that works with 1.2 as minimum.

We would however disrupt anyone relying on a package that requires a min. of promises 1.3. Considering 1.3 was released ~5 days ago, hopefully the blast radius is not too big. And the disruption would be failing static analysis checks, not buggy code.

@Ndiritu Ndiritu merged commit 6a166a0 into dev Jan 10, 2024
4 of 9 checks passed
@Ndiritu Ndiritu deleted the fix/promise-generics branch January 10, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants