Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPUnit segfault in build checks with PHP 7.4 #122

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix PHPUnit segfault in build checks with PHP 7.4 #122

merged 2 commits into from
Jan 30, 2024

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Jan 9, 2024

No description provided.

@Ndiritu Ndiritu marked this pull request as draft January 9, 2024 13:10
@Ndiritu Ndiritu changed the title Enable display errors for debugging Enable display errors for debugging PHPUnit segfault Jan 9, 2024
SilasKenneth
SilasKenneth reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@SilasKenneth SilasKenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was already fixed. You should change xdebug to version 2. Please check the authentication repo for reference.

@Ndiritu
Copy link
Contributor Author

Ndiritu commented Jan 9, 2024

This issue was already fixed. You should change xdebug to version 2. Please check the authentication repo for reference.

Aah nice! Thought the fix was adding a memory limit.
Porting the fix over.

@Ndiritu Ndiritu changed the title Enable display errors for debugging PHPUnit segfault Fix PHPUnit segfault with PHP 7.4 Jan 9, 2024
@Ndiritu Ndiritu changed the title Fix PHPUnit segfault with PHP 7.4 Fix PHPUnit segfault in build checks with PHP 7.4 Jan 9, 2024
@Ndiritu Ndiritu changed the base branch from dev to fix/promise-generics January 9, 2024 13:36
Base automatically changed from fix/promise-generics to dev January 10, 2024 12:02
@Ndiritu Ndiritu marked this pull request as ready for review January 10, 2024 12:05
@Ndiritu Ndiritu force-pushed the fix/debug-segfault branch 2 times, most recently from 0e739a4 to 987de1b Compare January 10, 2024 12:52
@Ndiritu Ndiritu marked this pull request as draft January 30, 2024 06:53
@Ndiritu Ndiritu self-assigned this Jan 30, 2024
@Ndiritu Ndiritu marked this pull request as ready for review January 30, 2024 07:01
@Ndiritu
Copy link
Contributor Author

Ndiritu commented Jan 30, 2024

@SilasKenneth I've set coverage to only run with PHP 8.0 and disabled coverage checks with other PHP versions since PHPUnit only throws the segmentation fault when Xdebug coverage is enabled and run with PHP 7.4

@Ndiritu Ndiritu mentioned this pull request Jan 30, 2024
Merged
@SilasKenneth
Copy link
Member

That looks okay for now. Eventually, we will have to drop support for PHP 7.4.

@Ndiritu Ndiritu merged commit 8b6e320 into dev Jan 30, 2024
7 checks passed
@Ndiritu Ndiritu deleted the fix/debug-segfault branch January 30, 2024 08:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

@SilasKenneth SilasKenneth Awaiting requested review from SilasKenneth

Assignees

@Ndiritu Ndiritu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ndiritu @SilasKenneth