-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiota with dependency injection dotnet #5733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Can I ask that you please:
- add a configuration in dependabot
- add a github workflow (build only)
Sure, here you go. |
@baywet are you able to have a look at my latest changes? If this is accepted I can also change the other pr to use the code in this sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, and for your patience (I was out)
One last thing and we should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
@svrooij the project doesn't seem to be building anymore for some reason, can you have a look please? |
@svrooij just making sure we don't loose momentum here :) |
@baywet i literally have no clue why it doesn't work.... It builds in Ubuntu on wsl and it builds on windows |
@svrooij it wasn't building on my machine either. Turns out files were missing for some reason. Generating and pushing files fixed it. Thank you for your patience. |
Sample code for: MicrosoftDocs/openapi-docs#89
Building and updating it, is not implemented. Want me to update the workflows as well?
@baywet here you go