Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiota with dependency injection dotnet #5733

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Kiota with dependency injection dotnet #5733

merged 8 commits into from
Jun 21, 2024

Conversation

svrooij
Copy link
Contributor

@svrooij svrooij commented May 23, 2024

Sample code for: MicrosoftDocs/openapi-docs#89

Building and updating it, is not implemented. Want me to update the workflows as well?

@baywet here you go

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
Can I ask that you please:

  • add a configuration in dependabot
  • add a github workflow (build only)

@svrooij
Copy link
Contributor Author

svrooij commented May 25, 2024

Thank you for the contribution! Can I ask that you please:

  • add a configuration in dependabot
  • add a github workflow (build only)

Sure, here you go.

@svrooij
Copy link
Contributor Author

svrooij commented Jun 10, 2024

@baywet are you able to have a look at my latest changes? If this is accepted I can also change the other pr to use the code in this sample

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, and for your patience (I was out)
One last thing and we should be good to go.

.github/workflows/get-started-dotnet.yml Show resolved Hide resolved
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

.github/workflows/get-started-dotnet.yml Outdated Show resolved Hide resolved
.github/workflows/get-started-dotnet.yml Outdated Show resolved Hide resolved
@baywet
Copy link
Member

baywet commented Jun 12, 2024

@svrooij the project doesn't seem to be building anymore for some reason, can you have a look please?

@baywet
Copy link
Member

baywet commented Jun 21, 2024

@svrooij just making sure we don't loose momentum here :)

@svrooij
Copy link
Contributor Author

svrooij commented Jun 21, 2024

@baywet i literally have no clue why it doesn't work.... It builds in Ubuntu on wsl and it builds on windows

@baywet
Copy link
Member

baywet commented Jun 21, 2024

@svrooij it wasn't building on my machine either. Turns out files were missing for some reason. Generating and pushing files fixed it. Thank you for your patience.

@baywet baywet merged commit 59d8681 into microsoft:main Jun 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants