Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Rollout a Kiota.Bundle package for all languages #4636

Open
sebastienlevert opened this issue May 9, 2024 · 19 comments
Open

[Epic] Rollout a Kiota.Bundle package for all languages #4636

sebastienlevert opened this issue May 9, 2024 · 19 comments
Labels
type:feature New experience request
Milestone

Comments

@sebastienlevert
Copy link
Contributor

Is your feature request related to a problem? Please describe the problem.

To support the new client generation, we need a new Kiota Core package. That needs to happen for every language.

Client library/SDK language

None

Describe the solution you'd like

We need a package that references all the Kiota packages so we can rely on a single package instead of all the packages + serialization. We also need a derived request adapter to auto-register the serialization pieces.

Additional context

No response

@sebastienlevert sebastienlevert added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels May 9, 2024
@sebastienlevert sebastienlevert moved this from Needs Triage 🔍 to Todo 📃 in Kiota May 9, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota May 9, 2024
@sebastienlevert sebastienlevert removed the status:waiting-for-triage An issue that is yet to be reviewed or assigned label May 9, 2024
@baywet
Copy link
Member

baywet commented May 10, 2024

Is core a name we're happy with? Defaults and rollup are good alternatives.

We should take that opportunity to move the dotnet repository to being a monorepo and align the version numbers like we've done for java and it simplifies community contributions, issues management, publishing and more.

@baywet baywet added this to the Backlog milestone May 10, 2024
@darrelmiller
Copy link
Member

If this is just a meta package, then core isn't the right name in my opinion. I'm not a fan of Rollup. Some alternatives:

Kiota.Bundle
Kiota.BaseLine
Kiota.Standard
Kiota.Starter

@baywet
Copy link
Member

baywet commented May 10, 2024

especially since we already have graph core packages on the other side, I don't want to get into "which core are you talking about?" discussions all the time...

@sebastienlevert
Copy link
Contributor Author

Kiota.Bundle it is!

@andrueastman
Copy link
Member

andrueastman commented Jul 4, 2024

From an all-language perspective we will ideally need to do the following (in order)

  1. Ensure the libraries to a mono repo structure. (This has already been done for TS,Java).
  1. Add a new package/project for the Kiota.Bundle that pulls/depends in the abstractions libraries. (We can probably start this for TS/java as they meet step 1).

  2. Expose a derived request adapter to auto-register the serialization pieces.

Open Questions.

  • Naming for the derived request adapter?

@baywet Anything you think I may have missed here?

(I can probably add issues for TS/Java step 2 if we think that some of the languages can be done before others.)

@andrueastman andrueastman modified the milestones: Backlog, Kiota v1.17 Jul 4, 2024
@baywet
Copy link
Member

baywet commented Jul 4, 2024

Please create the issues for the bundle packages for the languages that are already on a mono-repo.

@andrueastman
Copy link
Member

andrueastman commented Jul 5, 2024

Created issues for bundle packages for languages that meet step 1 criteria (already have mono-repo or won't have one (Go)).

Other languages will have step 2 issues created once they complete(or invalidate) step 1.

(Updated to include dotnet)

@KennethHoff
Copy link

What about simply calling it Kiota (without a suffix)

@sebastienlevert
Copy link
Contributor Author

I don't have just having Kiota without a suffix... In this case it would be Microsoft.Kiota to be specific. Does that clash with any other of our packages @baywet ?

@baywet
Copy link
Member

baywet commented Jul 8, 2024

In the case of dotnet, it'll have to be something along the lines of Microsoft.Kiota.Bundle as it must be under Microsoft (or Azure, or a few other options) from a branding perspective. And our team only has permissions on the Microsoft.Kiota prefix

@sebastienlevert
Copy link
Contributor Author

We can't release at the prefix level?

@baywet
Copy link
Member

baywet commented Jul 8, 2024

Meaning just Microsoft.Kiota?

@andrueastman
Copy link
Member

We can't release at the prefix level?

I believe we can. We have an example at https://www.nuget.org/packages/Microsoft.Graph

@baywet
Copy link
Member

baywet commented Jul 9, 2024

The only thing I'm worried about with this package name is it will introduce confusion with a generator itself. The current name for the generator .net tool is Microsoft.openapi.kiota. if we introduce the bundle package under microsoft.kiota, this will most likely lead to people trying to install that realize it's not the generation tool having to find the proper name of the generation tool and be mad at us for that reason.

@sebastienlevert
Copy link
Contributor Author

Good point. Could we think about a v2 of the Generator that could become Microsoft.Kiota.Generator?

@baywet
Copy link
Member

baywet commented Jul 9, 2024

Sure, we could rename things. We should be careful about including generator in the package name though in case kiota evolves to do more than just generation. (hidi features, etc...)

@andrueastman andrueastman moved this from Todo 📃 to In Progress 🚧 in Kiota Aug 6, 2024
@baywet baywet modified the milestones: Kiota v1.17, Kiota v1.18 Aug 9, 2024
@petrhollayms petrhollayms moved this from In Progress 🚧 to Todo 📃 in Kiota Aug 21, 2024
@andrueastman andrueastman changed the title Rollout a Kiota.Bundle package for all languages [Epic] Rollout a Kiota.Bundle package for all languages Aug 27, 2024
@timayabi2020 timayabi2020 moved this from Todo 📃 to In Progress 🚧 in Kiota Aug 29, 2024
@andrueastman
Copy link
Member

andrueastman commented Sep 3, 2024

As an update for this epic. This now rolled out for

We still need to close

for this to be resolved for PHP, Ruby and Python

@sebastienlevert
Copy link
Contributor Author

@andrueastman have we updated the required dependencies when we do kiota info --l typescript for instance?

@andrueastman
Copy link
Member

@andrueastman have we updated the required dependencies when we do kiota info --l typescript for instance?

Thanks for catching that. We'll need to update the info command on the generator this.

#5317 will track this for the 4 langauges and the rest will have it as part of the bundle work item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New experience request
Projects
Status: In Progress 🚧
Development

No branches or pull requests

6 participants