-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic] Rollout a Kiota.Bundle package for all languages #4636
Comments
Is core a name we're happy with? Defaults and rollup are good alternatives. We should take that opportunity to move the dotnet repository to being a monorepo and align the version numbers like we've done for java and it simplifies community contributions, issues management, publishing and more. |
If this is just a meta package, then core isn't the right name in my opinion. I'm not a fan of Rollup. Some alternatives: Kiota.Bundle |
especially since we already have graph core packages on the other side, I don't want to get into "which core are you talking about?" discussions all the time... |
Kiota.Bundle it is! |
From an all-language perspective we will ideally need to do the following (in order)
Open Questions.
@baywet Anything you think I may have missed here? (I can probably add issues for TS/Java step 2 if we think that some of the languages can be done before others.) |
Please create the issues for the bundle packages for the languages that are already on a mono-repo. |
Created issues for bundle packages for languages that meet step 1 criteria (already have mono-repo or won't have one (Go)).
Other languages will have step 2 issues created once they complete(or invalidate) step 1. (Updated to include dotnet) |
What about simply calling it |
I don't have just having Kiota without a suffix... In this case it would be Microsoft.Kiota to be specific. Does that clash with any other of our packages @baywet ? |
In the case of dotnet, it'll have to be something along the lines of |
We can't release at the prefix level? |
Meaning just Microsoft.Kiota? |
I believe we can. We have an example at https://www.nuget.org/packages/Microsoft.Graph |
The only thing I'm worried about with this package name is it will introduce confusion with a generator itself. The current name for the generator .net tool is Microsoft.openapi.kiota. if we introduce the bundle package under microsoft.kiota, this will most likely lead to people trying to install that realize it's not the generation tool having to find the proper name of the generation tool and be mad at us for that reason. |
Good point. Could we think about a v2 of the Generator that could become Microsoft.Kiota.Generator? |
Sure, we could rename things. We should be careful about including generator in the package name though in case kiota evolves to do more than just generation. (hidi features, etc...) |
As an update for this epic. This now rolled out for
We still need to close
for this to be resolved for PHP, Ruby and Python |
@andrueastman have we updated the required dependencies when we do |
Thanks for catching that. We'll need to update the info command on the generator this. #5317 will track this for the 4 langauges and the rest will have it as part of the bundle work item. |
Is your feature request related to a problem? Please describe the problem.
To support the new client generation, we need a new Kiota Core package. That needs to happen for every language.
Client library/SDK language
None
Describe the solution you'd like
We need a package that references all the Kiota packages so we can rely on a single package instead of all the packages + serialization. We also need a derived request adapter to auto-register the serialization pieces.
Additional context
No response
The text was updated successfully, but these errors were encountered: