Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugifx/vscode multiple windows install #4359

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Mar 19, 2024

fixes #3686

@baywet baywet requested a review from a team as a code owner March 19, 2024 20:17
@baywet baywet self-assigned this Mar 19, 2024
@baywet baywet enabled auto-merge March 19, 2024 20:17
auto-merge was automatically disabled March 19, 2024 20:22

Pull Request is not mergeable

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe more translation updates are coming, otherwise, this looks good to me.

vscode/microsoft-kiota/src/kiotaInstall.ts Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@baywet
Copy link
Member Author

baywet commented Mar 20, 2024

CC @treastrain since you kindly provided the Japanese translations

@baywet baywet merged commit 4aec462 into main Mar 20, 2024
193 checks passed
@baywet baywet deleted the bugifx/vscode-multiple-windows-install branch March 20, 2024 14:46
treastrain added a commit to treastrain/kiota that referenced this pull request Mar 20, 2024
treastrain added a commit to treastrain/kiota that referenced this pull request Mar 20, 2024
@treastrain
Copy link
Contributor

@baywet

CC @treastrain since you kindly provided the Japanese translations

I did it! #4363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

vscode kiota installation should use a semaphore
3 participants