Skip to content

Commit

Permalink
Make test criteria case-insensitive
Browse files Browse the repository at this point in the history
No testcase names, areas, or categories should differ only by case.
In many places, testcase areas are formatted with the first letter capitalized (ie. 'Sriov') however if anything other than all lowercase is used in the test critera, all tests will be skipped. This is bad user experience since it does not result in an error and it is unclear why no tests were selected.
  • Loading branch information
kamalca committed Sep 4, 2024
1 parent 225fb52 commit 148c934
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lisa/testselector.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def _apply_filter( # noqa: C901
constants.TESTCASE_CRITERIA_CATEGORY,
]:
pattern = cast(str, criteria_runbook_dict[runbook_key])
expression = re.compile(pattern)
expression = re.compile(pattern, re.IGNORECASE)
patterns.append(
partial(_match_string, pattern=expression, attr_name=runbook_key)
)
Expand Down

0 comments on commit 148c934

Please sign in to comment.