Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default value to avoid missing credential exception #3408

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

LiliDeng
Copy link
Collaborator

@LiliDeng LiliDeng commented Sep 5, 2024

Reverts #3395

it breaks current baremetal run

    raise LisaException(
lisa.util.LisaException: at least one of password or private_key_file need to be set when connecting

@LiliDeng LiliDeng requested a review from squirrelsc as a code owner September 5, 2024 04:19
@LiliDeng LiliDeng force-pushed the revert-3395-lildeng/fix_827_001 branch from 2c6db0b to 5a5e78e Compare September 5, 2024 09:06
@LiliDeng LiliDeng changed the title Revert "Use default_factory to initialize ConnectionInfo" set default value to avoid missing credential exception Sep 5, 2024
@LiliDeng LiliDeng force-pushed the revert-3395-lildeng/fix_827_001 branch from 5a5e78e to ce72b69 Compare September 5, 2024 09:12
@LiliDeng LiliDeng merged commit f7dd63a into main Sep 6, 2024
45 checks passed
@LiliDeng LiliDeng deleted the revert-3395-lildeng/fix_827_001 branch September 6, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants