Fix libvirt for mariner if already present #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If libvirt not present, install it and fix if distro is mariner If libvirt is present, fix it if distro is mariner Signed-off-by: Smit Gardhariya <[email protected]>
smit-gardhariya
requested review from
squirrelsc and
LiliDeng
as code owners
pupacha
reviewed
Sep 5, 2024
pupacha
approved these changes
Sep 5, 2024
LiliDeng
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If libvirt not present, install it and fix if distro is mariner
If libvirt is present, fix it if distro is mariner
We are implementing scenario-2 here. Scenario-1 was already there. To do so, Push fn
_fix_mariner_installationat common place and call the fn for both the scenarios.