Stabilize MPI tests for Azure Linux#3521
Closed
sandeepkarambelkar wants to merge 1 commit intomicrosoft:mainfrom
Closed
Stabilize MPI tests for Azure Linux#3521sandeepkarambelkar wants to merge 1 commit intomicrosoft:mainfrom
sandeepkarambelkar wants to merge 1 commit intomicrosoft:mainfrom
Conversation
squirrelsc
reviewed
Nov 20, 2024
| server_ssh.add_known_host(client_ip) | ||
| client_ssh.add_known_host(server_ip) | ||
| sudo=False | ||
| if isinstance(server_node.os, CBLMariner): |
Contributor
There was a problem hiding this comment.
Please add comments above to explain why Mariner needs sudo.
squirrelsc
reviewed
Nov 20, 2024
|
|
||
| # Only for mariner, we need to build intel benchmarking tools | ||
| # as they are not included in our packages | ||
| server_ib.install_intel_mpi_benchmarking_tool() |
Contributor
There was a problem hiding this comment.
Please also add if block here to skip other distros. So the logic here is easier to know at the test case level. The if block in the install_intel_mpi_benchmarking_tool is a safe guard.
squirrelsc
reviewed
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.