Check all log locations for if serial console enabled #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kat-lsg-dev
force-pushed
the
katm/serial-console-fix
branch
from
b807353 to
9b68adf
Compare
squirrelsc
reviewed
Jan 24, 2025
squirrelsc
reviewed
Jan 24, 2025
squirrelsc
reviewed
Jan 24, 2025
|
Make commits meaningful. |
kat-lsg-dev
force-pushed
the
katm/serial-console-fix
branch
2 times, most recently
from
ad3935a to
1dfcb9a
Compare
LiliDeng
reviewed
Jan 25, 2025
| 2. Check expected setting from kernel command line. | ||
| 2.1. Expected to see 'console=ttyAMA0' for aarch64. | ||
| 2.2. Expected to see 'console=ttyS0' for x86_64. | ||
| 2.3. Expected to see 'uart0: console 115200,n,8,1 for FreeBSD. |
There was a problem hiding this comment.
'uart0: console (115200,n,8,1)'
There was a problem hiding this comment.
good catch, fixed that
…etect serial console enabled
kat-lsg-dev
force-pushed
the
katm/serial-console-fix
branch
from
f820989 to
1229f42
Compare
|
@LiliDeng LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a potential bug in the logic of this test, where only some log locations are checked for the target substring. I manually ran the commands on an image which failed this test and discovered that the substring could be detected in the journalctl log. The test now checks all possible locations for the substring to ensure that it will be detected if present.