[Hyper-v platform] Enabling port forwarding when switch type is Internal #3615
+94
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRIKKANTH
changed the title
squirrelsc
reviewed
Jan 27, 2025
squirrelsc
reviewed
Jan 27, 2025
squirrelsc
reviewed
Jan 27, 2025
squirrelsc
reviewed
Jan 30, 2025
|
@LiliDeng LGTM |
Virtual machines with an internal switch type cannot be accessed from outside the host. To enable external access, you need to use NAT and port mapping.
SRIKKANTH
force-pushed
the
smyakam/hyperv/portforwarding_25_01_2025
branch
from
9e76932 to
edc24f7
Compare
LiliDeng
reviewed
Feb 3, 2025
| if port in self._assigned_nat_ports: | ||
| self._assigned_nat_ports.remove(port) | ||
| else: | ||
| print(f"Port {port} was not assigned.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual machines with an internal switch type cannot be accessed from outside the host. To enable external access, you need to use NAT and port mapping.