DI Refactor: Azure.Mcp.Tools.ApplicationInsights

[Copilot]

• Inject IApplicationInsightsService into RecommendationListCommand constructor (remove context.GetService<T>())
• Update RecommendationListCommandTests to pass service mock directly to command constructor
• Add shared _commandDefinition field to tests and use _commandDefinition.Parse(...) in test methods (Step 5)
• Fix test to fully match DI refactor pattern: rename _serviceMock → _applicationInsightsService, make logger a class field, use implicit new() syntax (Step 5)
• Add CHANGELOG entry via New-ChangelogEntry.ps1 with PR number (Step 5)
• Build and verify changes (2/2 tests pass)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>DI Refactor: Azure.Mcp.Tools.ApplicationInsights</issue_title>
<issue_description>## Summary

Refactor Azure.Mcp.Tools.ApplicationInsights to use constructor dependency injection instead of resolving services via context.GetService<T>() in ExecuteAsync.

This is a sub-issue of #158.

Instructions

Follow the algorithm described in tools/di-refactor-plan.md with {ToolArea} = ApplicationInsights.

An example PR is: #1815</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes DI Refactor: Azure.Mcp.Tools.ApplicationInsights #1836

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[conniey]

@copilot Verify that Step 5 was done correctly.

[Copilot]

@copilot Verify that Step 5 was done correctly.

Step 5 (shared _commandDefinition field in tests) was missing. Fixed in 529b4b9 — added private readonly Command _commandDefinition initialized in the constructor, and updated both test methods to use _commandDefinition.Parse(...) instead of _command.GetCommand().Parse(...).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• gist.github.com
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
• https://api.github.com/gists/e79f98b99222c07d5f319d6c0abdab27
  • Triggering command: /usr/bin/curl curl -s REDACTED (http block)
  • Triggering command: /usr/bin/curl curl -sf REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[conniey]

@copilot Double-check that Step 5 was done correctly.

[Copilot]

The test was missing a few parts of the Step 5 pattern. Fixed in a1970c9:

• Renamed _serviceMock → _applicationInsightsService (consistent with service name convention)
• Moved logger from local variable to private readonly ILogger<RecommendationListCommand> _logger class field
• Changed constructor call to use implicit new(_logger, _applicationInsightsService) syntax

The test now matches the same pattern as AccountListCommandTests (AppConfig).

[conniey]

@copilot Step 5 includes executing New-ChangeLogEntry.ps1 to generate CHANGELOG entry. This is not done.

[Copilot]

Done in 34ae7f6. Generated servers/Azure.Mcp.Server/changelog-entries/copilot-di-refactor-applicationinsights.yaml via New-ChangelogEntry.ps1 under "Other Changes".

[conniey]

@copilot it is missing the PR# in the generated changelog. try again.

[Copilot]

Added pr: 1899 to the changelog entry in 5e50fe2.

[Copilot]

@copilot Verify that Step 5 was done correctly.

Step 5 is now fully complete — the CHANGELOG entry was generated in 34ae7f6 via New-ChangelogEntry.ps1.