Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit Cloud tag to the server’s telemetry so emitted activities indicate which Azure cloud environment (Public/China/US Gov/custom authority) the MCP server is using.
Changes:
- Add
TagName.Cloudand include it inTelemetryServicedefault tags usingAzureCloudConfigurationparsing logic. - Refactor
AzureCloudConfigurationto expose reusableLoadCloudValueandParseCloudValuehelpers (internal) for shared cloud resolution behavior. - Extend
TelemetryServiceTestswith new cases validating cloud tag selection fromServiceStartOptionsandIConfiguration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/changelog-entries/1772564548835.yaml | Adds changelog entry documenting the telemetry change. |
| core/Microsoft.Mcp.Core/tests/Microsoft.Mcp.Core.UnitTests/Services/Telemetry/TelemetryServiceTests.cs | Adds/updates unit tests to assert Cloud tagging behavior. |
| core/Microsoft.Mcp.Core/src/Services/Telemetry/TelemetryService.cs | Adds Cloud tag computation and injection of IConfiguration. |
| core/Microsoft.Mcp.Core/src/Services/Azure/Authentication/AzureCloudConfiguration.cs | Extracts cloud-value load/parse logic into internal helpers. |
| core/Microsoft.Mcp.Core/src/Commands/TelemetryConstants.cs | Introduces the Cloud telemetry tag name constant. |
core/Microsoft.Mcp.Core/src/Services/Telemetry/TelemetryService.cs
Outdated
Show resolved
Hide resolved
...soft.Mcp.Core/tests/Microsoft.Mcp.Core.UnitTests/Services/Telemetry/TelemetryServiceTests.cs
Outdated
Show resolved
Hide resolved
conniey
reviewed
Mar 4, 2026
core/Microsoft.Mcp.Core/src/Services/Azure/Authentication/AzureCloudConfiguration.cs
Outdated
Show resolved
Hide resolved
conniey
reviewed
Mar 4, 2026
core/Microsoft.Mcp.Core/src/Services/Azure/Authentication/AzureCloudConfiguration.cs
Outdated
Show resolved
Hide resolved
conniey
reviewed
Mar 4, 2026
core/Microsoft.Mcp.Core/src/Services/Telemetry/TelemetryService.cs
Outdated
Show resolved
Hide resolved
conniey
requested changes
Mar 4, 2026
conniey
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new telemetry
Cloudto the start of theTelemetryServiceto indicate which Azure cloud environment the MCP server is using. TheCloudvalue will be one of theAzureCloudenum values, which are the following at this time:AzurePublicCloudAzureChinaCloudAzureUSGovernmentCloudGitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline