-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ConversationIndex parsing #813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwittgen
reviewed
Jan 21, 2025
bwittgen
reviewed
Jan 21, 2025
bwittgen
reviewed
Jan 21, 2025
bwittgen
reviewed
Jan 21, 2025
bwittgen
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit picking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
core/smartview
module, focusing on improving the parsing logic and adding new functionalities. The most important changes include refactoring theConversationIndex
parsing, updating theflagArray
entries, and adding performance tracking to the fuzzing tests.Parsing Logic Improvements:
core/smartview/ConversationIndex.cpp
: Refactored theResponseLevel::parse
method to simplify the parsing logic and added a new methodAddFileTime
to handle FILETIME calculations. [1] [2]core/smartview/ConversationIndex.h
: Updated theResponseLevel
andConversationIndex
classes to include new member variables and constructors for improved parsing. [1] [2] [3]Flag Array Updates:
core/interpret/flagArray.h
: Modified theflagReportTagVersion
entry to update its version number.Fuzzing and Performance Tracking:
fuzz/fuzz.cpp
: Added performance tracking for each parser type, logging the average time per test after every 1000 tests.Other Changes:
UnitTest/SmartViewTestData/In/CONVERSATIONINDEX-1.dat
andUnitTest/SmartViewTestData/In/CONVERSATIONINDEX-4.dat
: Reformatted data files for better readability. [1] [2]mapistub
: Updated the submodule commit reference.