Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConversationIndex parsing #813

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Fix ConversationIndex parsing #813

merged 7 commits into from
Jan 21, 2025

Conversation

stephenegriffin
Copy link
Member

This pull request includes several changes to the core/smartview module, focusing on improving the parsing logic and adding new functionalities. The most important changes include refactoring the ConversationIndex parsing, updating the flagArray entries, and adding performance tracking to the fuzzing tests.

Parsing Logic Improvements:

Flag Array Updates:

Fuzzing and Performance Tracking:

  • fuzz/fuzz.cpp: Added performance tracking for each parser type, logging the average time per test after every 1000 tests.

Other Changes:

  • UnitTest/SmartViewTestData/In/CONVERSATIONINDEX-1.dat and UnitTest/SmartViewTestData/In/CONVERSATIONINDEX-4.dat: Reformatted data files for better readability. [1] [2]
  • mapistub: Updated the submodule commit reference.

Copy link

github-actions bot commented Jan 21, 2025

Test Results

    8 files  ±0      8 suites  ±0   50s ⏱️ +4s
  251 tests ±0    251 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 008 runs  ±0  2 008 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b2a73bd. ± Comparison against base commit 37a5584.

♻️ This comment has been updated with latest results.

@stephenegriffin stephenegriffin enabled auto-merge (squash) January 21, 2025 15:23
Copy link

@bwittgen bwittgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit picking changes

@stephenegriffin stephenegriffin merged commit c2fd771 into main Jan 21, 2025
16 checks passed
@stephenegriffin stephenegriffin deleted the u/sgriffin/test branch January 21, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants