Skip to content

Conversation

kmahone
Copy link
Member

@kmahone kmahone commented Sep 11, 2024

No description provided.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Sep 11, 2024
@kmahone kmahone marked this pull request as draft September 11, 2024 20:32
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Left a few updates following the latest changes in CsWinRT/tooling 🙂

@@ -28,6 +41,10 @@
<file target="lib\uap10.0\Microsoft.UI.Xaml\Themes" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml\Generic.xaml"/>
<file target="lib\uap10.0\Design" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml.Design\Microsoft.UI.Xaml.design.dll"/>

<file target="lib\net8.0-windows10.0.22621.0\Microsoft.UI.Xaml.Projection.dll" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml.Projection\Microsoft.UI.Xaml.Projection.dll" />
<file target="lib\net8.0-windows10.0.22621.0\Microsoft.UI.Xaml\Themes" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml\Generic.xaml"/>
<file target="lib\net8.0-windows10.0.22621.0" src="Intellisense\Microsoft.UI.Xaml.xml"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to match the name of this .xml to the projection .dll (same for the other .nuspec files):

Suggested change
<file target="lib\net8.0-windows10.0.22621.0" src="Intellisense\Microsoft.UI.Xaml.xml"/>
<file target="lib\net8.0-windows10.0.22621.0\Microsoft.UI.Xaml.Projection.xml" src="Intellisense\Microsoft.UI.Xaml.xml"/>

@Gaoyifei1011
Copy link

_ No description provided. _

.NET 9 and Visual Studio 2022 version 17.12 have been released, and UWP.NET 9 has been supported. Is the Projection of WinUI 2 yet to be updated

-------------------------------------------------

.NET 9 和 Visual Studio 2022 17.12 正式版已经发布了,已经支持了 UWP .NET 9,想问一下 WinUI 2 的 Projection 还没有更新吗

<DisableRuntimeMarshalling>true</DisableRuntimeMarshalling>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<WindowsSdkPackageVersion>10.0.22621.54</WindowsSdkPackageVersion>
<UseRidGraph>true</UseRidGraph>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should no longer need UseRidGraph here in VS 17.12 stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the CI has been updated with the .NET 9 SDK yet. Let's just keep this for now just in case.

@Gaoyifei1011
Copy link

Gaoyifei1011 commented Nov 23, 2024

_ No description provided. _

Microsoft.UI.Xaml.Projection.dll 文件的公司名称写错了,应该是 Microsoft Corporation,而不是 Microsoft.UI.Xaml.Projection。
而且文件的产品版本(ProductVersion)多了一串意外的字符串,应该使用 AssemblyInfo.cs 来定义文件的产品版本,而不是直接使用 csproj 的文件属性来定义

---------------------------------------------------

The company name of the Microsoft.UI.Xaml.Projection.dll file is misspelled and should be Microsoft Corporation, not Microsoft.UI.Xaml.Projection.
Also, the ProductVersion of the file has an unexpected string, and the AssemblyInfo.cs should be used to define the product version of the file, rather than directly using the csproj file properties

d8b07d2dd55c3361376f1ae95ebb7484

@Sergio0694
Copy link
Member

@Gaoyifei1011 thank you for trying this out!

  • Yeah the company name is wrong, I'll fix that
  • The product version is correct, and the BCL does the same. For context, see semantic versioning. Additionally, it is not actually recommended to use AssemblyInfo.cs for new projects. SDK-style projects should just set Version and let the .NET SDK set all the other properties, like we're doing here 🙂

@Gaoyifei1011
Copy link

@Gaoyifei1011 thank you for trying this out!

  • Yeah the company name is wrong, I'll fix that
  • The product version is correct, and the BCL does the same. For context, see semantic versioning. Additionally, it is not actually recommended to use AssemblyInfo.cs for new projects. SDK-style projects should just set Version and let the .NET SDK set all the other properties, like we're doing here 🙂

All right. Thank you for your correction

@Gaoyifei1011
Copy link

@Gaoyifei1011 thank you for trying this out!

  • Yeah the company name is wrong, I'll fix that
  • The product version is correct, and the BCL does the same. For context, see semantic versioning. Additionally, it is not actually recommended to use AssemblyInfo.cs for new projects. SDK-style projects should just set Version and let the .NET SDK set all the other properties, like we're doing here 🙂

@Gaoyifei1011 thank you for trying this out!

  • Yeah the company name is wrong, I'll fix that
  • The product version is correct, and the BCL does the same. For context, see semantic versioning. Additionally, it is not actually recommended to use AssemblyInfo.cs for new projects. SDK-style projects should just set Version and let the .NET SDK set all the other properties, like we're doing here 🙂

image
It seems that after the official release of WinUI 2 2.8.7, the content has not been modified

----------------------------

似乎 WinUI 2 2.8.7 正式版公布后,内容并未修改

@Sergio0694
Copy link
Member

I guess we can fix that in the next patch release, it shouldn't really matter too much anyway 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue needs to be triaged by the area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants