Add code review comments, remove nodefqdn from LNET

microsoft · Jul 14, 2023 · feac410 · feac410
1 parent 32507ed
commit feac410
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 60 deletions.
diff --git a/rpc/cloudagent/network/logicalnetwork/moc_cloudagent_logicalnetwork.proto b/rpc/cloudagent/network/logicalnetwork/moc_cloudagent_logicalnetwork.proto
@@ -25,11 +25,10 @@ message LogicalNetwork {
 	string id = 2;
 	repeated LogicalSubnet subnets = 3;
 	bool networkVirtualizationEnabled = 4;
-	string nodefqdn = 5;
-	Status status = 6;
-	string locationName = 7;
-	string macPoolName = 8;
-	Tags tags = 9;
+	Status status = 5;
+	string locationName = 6;
+	string macPoolName = 7 [(sensitive) = true];
+	Tags tags = 8;
 }
 
 message LogicalSubnet {
@@ -40,8 +39,8 @@ message LogicalSubnet {
 	IPAllocationMethod allocation = 5;
 	uint32 vlan = 6;
 	repeated IPPool ipPools = 7;
-	Dns dns = 8; 
-	bool isPublic = 9;
+	Dns dns = 8 [(sensitive) = true]; 
+	bool isPublic = 9; // Indicates whether this is a public subnet on a virtual machine.
 }
 
 service LogicalNetworkAgent {

diff --git a/rpc/cloudagent/network/moc_cloudagent_logicalnetwork.pb.go b/rpc/cloudagent/network/moc_cloudagent_logicalnetwork.pb.go
diff --git a/rpc/cloudagent/network/networkinterface/moc_cloudagent_networkinterface.proto b/rpc/cloudagent/network/networkinterface/moc_cloudagent_networkinterface.proto
@@ -38,7 +38,7 @@ message IpConfiguration {
 	IPAllocationMethod allocation = 6;
 	string gateway = 7 [(sensitive) = true];
 	repeated InboundNatRule inboundNatRules = 8;
-	NetworkType networkType = 9;
+	NetworkType networkType = 9; // Read-only property
 }
 
 message NetworkInterface {