-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tags to the IpConfiguration Datastructure #166
Conversation
…e PrimaryIpAddress from a Network Interface
…moc into user/gsiciliano/feat-multiIp2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madhanrm I'm not sure about adding Tags to IpConfiguration
here. Could you please take a look?
The added Tags are being used to store the resourceId/guid assigned to the ipConfiguration within the NetworkController. The guids need to be saved somewhere in Moc to allow update and syncing the ipConfigurations to NC. Guids present in NC that aren't in Moc are deleted for example. Tags were used here in IpConfiguration because the Tag property was also used in NetworkInterface, and NC uses the same method to update the NetworkInterfaces by storing the NC NIC resourceId in the Tag of Moc's NetworkInterface object. |
@madhanrm, if there are no other comments, this PR will be completed by the middle of this week |
…moc into user/gsiciliano/feat-multiIp2
I am merging this PR. Following are the pipelines executed for this on top of wssdcloudagent. Moc-cicd (modified with multi-ip tests): Pipelines - Run 20230821.9 (visualstudio.com) |
Add Tags value to the IpConfiguration data structure. This will be used to store the NC resource Id.
Also add a function to NetworkInterface to get the primary Ip Configuration from the list of IpConfigurations