Moc protobuf change for checking TVM capabilities #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmamsft
requested review from
raghavendra-nataraj,
madhanrm,
SethBe and
a team
rpc/common/moc_common_nodeinfo.proto
Outdated
| @@ -33,6 +33,7 @@ message GPU { | |||
| message OperatingSystem { | |||
| uint64 operatingsystemsku = 1; | |||
| OperatingSystemType ostype = 2; | |||
| string operatingsystembuildnumber = 3; | |||
There was a problem hiding this comment.
This is looking different from the design doc. Is there a reason for the difference?
There was a problem hiding this comment.
The OS version is what we want to check which is the OS build number. I named it build number to be consistent with wmi property name (the wmi property name is called build number)
Since the type is simply string, there is no need to create another type and define the type as string.
There was a problem hiding this comment.
Makes sense. We usually align closely to azure-sdk. This makes the code extensisble when azure adds new feature.
raghavendra-nataraj
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first change for exposing TVM capabilities.
New properties are added to MOC rpc based on this design:
https://github.com/microsoft/wssdagent/blob/master/doc/features/AzureStackHCI/tvm.md
There will be followup PRs to in moc-pkg and node agent after this is checked in
I have coded up in moc-pkg to fill in these properties and tested node agent can get the properties properly.