SLB Proto Update #267
Draft
SLB Proto Update #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijosmsft
reviewed
Jun 19, 2024
| repeated LoadbalancerOutboundNatRule outboundNatRules = 6; //read-only | ||
| repeated LoadBalancingRule loadbalancingrules = 7; //read-only | ||
|
|
||
| LoadBalancerVipConfigurationState configurationState = 8; // Do we need to surface this? how is it different from Probes? |
nijosmsft
reviewed
Jun 19, 2024
| message FrontEndIpConfiguration { | ||
| string privateIPAddress = 1; // required if using subnet | ||
| IPAllocationMethod allocationMethod = 2; // required | ||
| string subnetRef = 3; // required if using privateIPAddress. Pass just the name or fully qualified ref? |
nijosmsft
reviewed
Jun 19, 2024
| @@ -47,6 +76,11 @@ message LoadBalancer { | |||
| Tags tags = 11; | |||
| uint32 replicationCount = 12; | |||
| repeated LoadbalancerInboundNatRule inboundNatRules = 13; | |||
| repeated LoadbalancerInboundNatRule outboundNatRules = 14; | |||
mjethwa-msft
commented
Jun 19, 2024
| google.protobuf.BoolValue Result = 2; | ||
| string Error = 3; | ||
| } | ||
|
|
There was a problem hiding this comment.
This file was WIP, so please ignore the formatting here. Below are the public IP properties listed from moc-sdk-for-go.
nijosmsft
reviewed
Jun 19, 2024
| uint32 backendPort = 3; | ||
| Protocol protocol = 4; | ||
| } | ||
|
|
||
| message LoadBalancingRule { |
nijosmsft
reviewed
Jun 19, 2024
| uint32 numberOfProbes = 2; | ||
| Protocol protocol = 3; | ||
| uint32 port = 4; | ||
| repeated LoadBalancingRule loadbalancingrules = 5; //read-only |
The proto changes? or any anything in specific? |
mjethwa-msft
force-pushed
the
user/mjethwa-msft/slb
branch
from
63551b9
to
fd76a45
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/slb
branch
from
fd76a45
to
5528b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.