Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Precheck RPC for various resources #269

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Add Precheck RPC for various resources #269

merged 3 commits into from
Jun 27, 2024

Conversation

aeweston-msft
Copy link
Contributor

@aeweston-msft aeweston-msft commented Jun 21, 2024 •
edited
Loading

Changes introduced by this PR

Adding precheck RPC definition for the following resources:

  • Identity (security)
  • Availability set (compute)
  • Gallery image (compute)
  • Virtual machine image (compute)
  • Load balancer (network)
  • Logical network (network)
  • MAC pool (network)
  • Network interface (network)
  • Network security group (network)
  • VIP pool (network)
  • Virtual network (network)
  • Container (storage)

Test plan

  • Have sanity checked the new precheck API for the storage container resource including cloudagent and moc-sdk-for-go changes. Since the Precheck RPC definition is common except for the resource types, I think this is a sufficient minimum of testing.

@aeweston-msft aeweston-msft mentioned this pull request Jun 26, 2024
Merged
@aeweston-msft aeweston-msft force-pushed the user/aweston/other-resource-prechecks branch from c2bd73c to aa186ca Compare June 26, 2024 22:43
@aeweston-msft aeweston-msft marked this pull request as ready for review June 26, 2024 22:43
@aeweston-msft
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aeweston-msft
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ganeshamohana
Copy link
Contributor

LGTM

@aeweston-msft aeweston-msft merged commit 48f405a into main Jun 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshamohana ganeshamohana ganeshamohana approved these changes

@apluchik apluchik apluchik approved these changes

@raghavendra-nataraj raghavendra-nataraj raghavendra-nataraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aeweston-msft @ganeshamohana @raghavendra-nataraj @apluchik