-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added availability zone proto #271
Merged
mkatturu
merged 30 commits into
microsoft:main
from
mkatturu:users/mkatturu/AvailabilityZonesChanges
Aug 23, 2024
Merged
added availability zone proto #271
mkatturu
merged 30 commits into
microsoft:main
from
mkatturu:users/mkatturu/AvailabilityZonesChanges
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mkatturu/moc into users/mkatturu/AvailabilityZonesChanges
piyushka17
reviewed
Jul 22, 2024
rpc/cloudagent/compute/availabilityzone/moc_cloudagent_availabilityzone.proto
Outdated
Show resolved
Hide resolved
rpc/cloudagent/compute/availabilityzone/moc_cloudagent_availabilityzone.proto
Outdated
Show resolved
Hide resolved
rpc/cloudagent/compute/availabilityzone/moc_cloudagent_availabilityzone.proto
Outdated
Show resolved
Hide resolved
rpc/cloudagent/compute/availabilityzone/moc_cloudagent_availabilityzone.proto
Outdated
Show resolved
Hide resolved
rpc/cloudagent/compute/virtualmachine/moc_cloudagent_virtualmachine.proto
Outdated
Show resolved
Hide resolved
bgriddaluru
force-pushed
the
users/mkatturu/AvailabilityZonesChanges
branch
from
July 25, 2024 06:59
18e4ce7
to
bf676cf
Compare
bgriddaluru
reviewed
Jul 25, 2024
rpc/cloudagent/cloud/availabilityzone/moc_cloudagent_availabilityzone.proto
Outdated
Show resolved
Hide resolved
bgriddaluru
reviewed
Jul 25, 2024
piyushka17
requested review from
msftpgayam,
raghavendra-nataraj and
JocelynBerrendonner
July 27, 2024 01:31
msftpgayam
requested changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add roles for RBAC.
rpc/cloudagent/cloud/availabilityzone/moc_cloudagent_availabilityzone.proto
Outdated
Show resolved
Hide resolved
msftpgayam
previously approved these changes
Aug 2, 2024
piyushka17
previously approved these changes
Aug 3, 2024
Azure Pipelines successfully started running 1 pipeline(s). |
msftpgayam
previously approved these changes
Aug 12, 2024
mkatturu
dismissed stale reviews from msftpgayam and raghavendra-nataraj
via
August 12, 2024 22:02
e4fdaf4
raghavendra-nataraj
previously approved these changes
Aug 14, 2024
msftpgayam
previously approved these changes
Aug 14, 2024
mkatturu
dismissed stale reviews from msftpgayam and raghavendra-nataraj
via
August 15, 2024 01:08
c83fe87
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit c83fe87.
mkatturu
commented
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
piyushka17
previously approved these changes
Aug 15, 2024
mkatturu
requested review from
msftpgayam
and removed request for
JocelynBerrendonner
August 15, 2024 21:10
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
msftpgayam
approved these changes
Aug 23, 2024
piyushka17
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.