FEAT: Add support for testing against SQL Server 2025 across Windows, macOS, and Linux CI pipelines#389
Merged
gargsaumya merged 6 commits intomainfrom Jan 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for testing against SQL Server 2025 across Windows, macOS, and Linux CI pipelines. The changes introduce new matrix configurations and installation steps for SQL Server 2025, extending test coverage to the upcoming SQL Server release.
Key Changes:
- Added SQL Server 2025 matrix entries across all three platforms (Windows, macOS, Linux) using Python 3.14
- Implemented SQL Server 2025 Express installation and setup steps for Windows pipeline
- Extended AdventureWorks2022 database restore and performance benchmarking to run on SQL Server 2025
- Modified macOS and Linux pipelines to pull and test against SQL Server 2025 Docker images
Comments suppressed due to low confidence (1)
eng/pipelines/pr-validation-pipeline.yml:71
- Python 3.14 may not be available through the UsePythonVersion@0 task without additional configuration. The build pipeline in OneBranchPipelines/stages/build-windows-single-stage.yml shows that Python 3.14 requires special handling with NuGet downloads (lines 64-107) because "Microsoft hasn't added Python 3.14 to the standard Python registry yet". This PR validation pipeline uses UsePythonVersion@0 with a githubToken parameter at line 70, but doesn't include the special installation steps needed for Python 3.14. This will likely cause the pipeline to fail when trying to use Python 3.14.
SQLServer2025:
sqlVersion: 'SQL2025'
pythonVersion: '3.14'
LocalDB_Python314:
sqlVersion: 'LocalDB'
pythonVersion: '3.14'
steps:
- task: UsePythonVersion@0
inputs:
versionSpec: '$(pythonVersion)'
addToPath: true
githubToken: $(GITHUB_TOKEN)
displayName: 'Use Python $(pythonVersion)'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.helpers.py: 67.5%
mssql_python.pybind.ddbc_bindings.cpp: 69.3%
mssql_python.pybind.ddbc_bindings.h: 71.7%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 83.9%🔗 Quick Links
|
bewithgaurav
approved these changes
Jan 5, 2026
jahnvi480
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request adds support for testing against SQL Server 2025 across Windows, macOS, and Linux CI pipelines. It introduces new matrix configurations, installation steps, and test/benchmark execution for SQL Server 2025, ensuring the project is validated on the upcoming SQL Server release as well as existing versions.
CI Pipeline Enhancements for SQL Server 2025:
Windows pipeline updates:
SQLServer2025with Python 3.14 to the Windows pipeline, alongside the installation and setup scripts for SQL Server 2025 Express, including database and user creation steps. [1] [2]macOS and Linux pipeline updates:
General improvements:
Other minor changes:
git rmandgit checkoutcommands in the ADO sync pipeline to exclude the.gdndirectory from removal and checkout, preventing accidental deletion of required files.