Added ability to start Splunk queries as a job/async #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check to nbinit.py to check and print status of Azure CLI login (if AzureCLI is installed) Changed azure_ml_tools.py to print out the installed rather than required version of MSTICPy Added unit test for check_cli_credentials in test_azure_auth_core.py Updated version to 1.4.4
…/microsoft/msticpy into pebryan/2021-8-18_IncidentTriage
entity.py: - removed edges from properties property - so comparisons don't take into account edge differences - added edges to str/repr - fixed possible None reference in description_str - fixed mypy warnings in to_networkx - renamed ent_camel to camelcase_property_names Added shortname property to RegistryHive enum in entity_enums.py Fixed missing closing parenthesis in repr of entity_graph Edge Change .format to use f-string in network_connection.py Updated name_str property to be more unique (added PID) in process.py Updated description_str and name_str properties to be more unique in registry_key.py Updated description_str and name_str properties to be more unique in registry_value.py Removed redundant AdditionalProperties initializer in incident.py (this is done in Entity init) Fixed detecting process with a parent in security_base.py (previously was based on comparison of entities, which does not work if the 2 entities have different edge sets. entity_graph_tools.py: - renamed _check_type_create to _add_incident_or_alert (more descriptive of what it does) - reworking plot methods a little - adding timeline param to choose whether you want a timeline. Added kwargs passthrough of params to the plot_entitygraph function. mp_pandas_plot.py: - renamed inc_graph to incident_graph - added kwargs and docstring info test_security_alert.py - a bit of tidying test_entity_graph.py: - typos, sorted imports, fixed #nodes in test cases for new name_str entity properties - fixed failing test_node_remove test case - added test_df_plot function for mp_pandas_plot accessor.
…ormance on AML (microsoft#212) * Implemented lazy loading of tabs to try to improve performance on AML By default it only instantiates and loads the first tab - others are loaded on demand as tabs are clicked * Added some UI labels to indicate that things are loading. Making entities json-serializable (hitch-hiker on this PR) * Needed to create a JSONEncoder class for entities to work with json.dumps ```python json.dumps(entity, cls=entities.Entity.JSONEncoder) * Updating version to 1.4.5
…write-2022-01-27 Ianhelle/data docs rewrite 2022 01 27
…urityAlertEntity SentinelAlert entity creation
Replaced requests with httpx 0.18
…xfix Updating httpx requirements to work with out requirements
…write-2022-01-27 Change to Querylist doc and py script to avoid phantom changes
|
@petebryan Got most of the issues resolved, need one addition to fix the unit test :) I'll push the final version tomorrow |
|
Due to an issue we had to reset the main branch so I've recreated your PR here #337 I've also added in elements to the unit tests to process async queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default 'oneshot' method is a blocking HTTP call which may often result in a timeout from various proxies. This change runs the query as a 'job' and polls the status until the job is completed (with a progress bar). The results are fetched after the while loop. The original oneshot query can still be used by specifying oneshot=True, ex. splunk_provider.Alerts.list_all_alerts(oneshot=True)