Update methodology of getting endpoints for cloud environment #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will now use arm to get endpoints for each environment Allow user to get endpoints by listing the arm url, useful if cloud is not global, cn, or usgov Update documentation Deprecate de/Germany since the cloud is also deprecated Create offline endpoints for global, cn and usgov for mocking Remove hardcoded urls that may touch only global endpoints
ianhelle
requested changes
Sep 6, 2023
|
I suspect some of the changes will trigger linter/code format warnings but these should be straightforward to fix |
ianhelle
reviewed
Sep 6, 2023
…elli22/msticpy into ccianelli/update_endpoints
Update get_subscription_metadata within ce_common this will first retrieve a 401 error to get the tenant id from the response, then will try the request again by getting an access token. This way we can get all of the metadata for the subscription fix typing error for get_managed_tenant_id within ce_common Add tenant_id to azure_auth add tenant_id to keyvault_settings
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ianhelle
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will now use arm to get endpoints for each environment
Allow user to get endpoints by listing the arm url, useful if cloud is not global, cn, or usgov
Update documentation
Deprecate de/Germany since the cloud is also deprecated
Create offline endpoints for global, cn and usgov for mocking
Remove hardcoded urls that may touch only global endpoints