Skip to content

Commit

Permalink
[SQUASH ON REBASE] Revert "MdePkg/CompilerIntrinsicsLib: Add Intrinsi…
Browse files Browse the repository at this point in the history
…cLib class and strcmp" (#1086)

## Description

The `strcmp` function was added to
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c in edk2 commit
46226fb. Therefore, ARM and AARCH64 modules can pick up the `strcmp`
function needed to compile code from there without adding more
functionality to `CompilerIntrinsicsLib` just for building third-party
crypto code.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [x] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

- CrytoBinPkg build of all architectures
- Mu Basecore CI

## Integration Instructions

- `strcmp` will no longer be provided in `ArmCompilerIntrinsicsLib`, use
another implementation if needed. Marked potentially breaking for this
reason.

Signed-off-by: Michael Kubacki <[email protected]>
  • Loading branch information
makubacki authored Aug 2, 2024
1 parent 2d0669d commit c32862a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 36 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@
MODULE_TYPE = BASE
VERSION_STRING = 1.0
LIBRARY_CLASS = CompilerIntrinsicsLib
LIBRARY_CLASS = IntrinsicLib # MU_CHANGE: Support IntrinsicLib linking

[Sources]

strcmp.c # MU_CHANGE: Add strcmp implementation
memcpy.c | GCC
memset.c | GCC

Expand Down
34 changes: 0 additions & 34 deletions MdePkg/Library/CompilerIntrinsicsLib/strcmp.c

This file was deleted.

0 comments on commit c32862a

Please sign in to comment.