2405: Crypto Changes [Rebase & FF] #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
type:design-change
github-actions
bot
added
language:python
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #951 +/- ##
=================================================
Coverage ? 44.35%
=================================================
Files ? 180
Lines ? 24408
Branches ? 3478
=================================================
Hits ? 10827
Misses ? 13545
Partials ? 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
force-pushed
the
2405_crypto
branch
3 times, most recently
from
328c78c
to
36e3675
Compare
|
I'm going to push an update for changing |
Add Variable Argument List macros for VS Related work items: #15744568
A Mu-specific change to copy/paste the VA macro definitions from Microsoft Visual Studio\<year>\Enterprise\VC\Tools\MSVC\<version>\include\vadefs.h causes some macros to be redefined when Google host-based tests are enabled (e.g. `_ADDRESSOF()`). This change uses the original definitions in `vadefs.h` to prevent a macro redefinition error when building host-based unit tests. Signed-off-by: Michael Kubacki <[email protected]>
Since we need to undefine M_ARM64 to get crypto to build, we add custom macros to let Base.h know we are actually really building ARM (just don't tell crypto)
Test is currently using FreePool() when it should use HmacSha256Free()
The documentation says "DER formatted", but the code was expecting it to be a pre-processed X509 structure. Add the additional processing.
Resolves CodeQL issues in the package. Co-authored-by: Aaron Pop <[email protected]> Co-authored-by: Kun Qin <[email protected]> Co-authored-by: Taylor Beebe <[email protected]> Co-authored-by: Doug Flick <[email protected]> Co-authored-by: Ken Lautner <[email protected]> Signed-off-by: Michael Kubacki <[email protected]>
Updated |
This was
linked to
issues
Jun 26, 2024
apop5
approved these changes
Jun 26, 2024
Javagedes
approved these changes
Jun 26, 2024
kenlautner
approved these changes
Jun 26, 2024
Updates to the code to match the latest Shared Crypto code in the release/202311 branch using the 2023.11.3 binary. For Shared Crypto details and platform integration information, review https://github.com/microsoft/mu_crypto_release. Other notable changes include: - Reconfigures OpensslLib to add elliptic curve chipher algorithms. - Fixes a memory fre bug in the HmacTest - Test is currently using FreePool() when it should use HmacSha256Free() - Adds SHA384 and SHA512 to the STANDARD flavor of the crypto binary Co-authored-by: Mike Turner <[email protected]> Co-authored-by: Bret Barkelew <[email protected]> Co-authored-by: Kenneth Lautner <[email protected]> Signed-off-by: Michael Kubacki <[email protected]>
Updates the CryptoPkg library instances used after the Shared Crypto changes in CryptoPkg. Signed-off-by: Michael Kubacki <[email protected]>
Updates the UefiCpuPkg library instances used after the Shared Crypto changes in CryptoPkg. Signed-off-by: Michael Kubacki <[email protected]>
…to is added)" This reverts commit now that CryptoPkg is buildable and in its final state for 2405. Signed-off-by: Michael Kubacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #871
All CryptoPkg changes to match the
release/202311branch.Updates some other packages to account for changes in libraries
used in CryptoPkg.
Transition to Latest Shared Crypto
Updates to the code to match the latest Shared Crypto code in the
release/202311 branch using the 2023.11.3 binary.
For Shared Crypto details and platform integration information,
review https://github.com/microsoft/mu_crypto_release.
Other notable changes consolidated in this commit include:
Contains the following additional cherry-picked commits.
Includes these 2311 commits:
How This Was Tested
release/202311Integration Instructions
and integration information https://github.com/microsoft/mu_crypto_release