Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2405: Crypto Changes [Rebase & FF] #951

Merged
merged 13 commits into from
Jun 26, 2024
Merged

2405: Crypto Changes [Rebase & FF] #951

merged 13 commits into from
Jun 26, 2024

Commits on Jun 26, 2024

  1. Add Variable Argument List macros for VS 

    Add Variable Argument List macros for VS

Related work items: #15744568
    @dmitryantipov @makubacki
    dmitryantipov authored and makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    cc149a1 View commit details
    Browse the repository at this point in the history

  2. Base.h: Ignore VA macro Mu change when host tests are enabled 

    A Mu-specific change to copy/paste the VA macro definitions from
Microsoft Visual Studio\<year>\Enterprise\VC\Tools\MSVC\<version>\include\vadefs.h
causes some macros to be redefined when Google host-based tests
are enabled (e.g. `_ADDRESSOF()`).

This change uses the original definitions in `vadefs.h` to prevent a
macro redefinition error when building host-based unit tests.

Signed-off-by: Michael Kubacki <[email protected]>
    @makubacki
    makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2fc48b2 View commit details
    Browse the repository at this point in the history

  3. TCBZ2029: Fix AARCH64 Crypto builds 

    Since we need to undefine M_ARM64 to get crypto to build, we add custom macros to let Base.h know we are actually really building ARM (just don't tell crypto)
    @makubacki
    Matthew Carlson authored and makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5a28bb1 View commit details
    Browse the repository at this point in the history

  4. Remove support for deprecated crypto from BaseCryptLib.

    @makubacki
    Bret Barkelew authored and makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8ccae26 View commit details
    Browse the repository at this point in the history

  5. TCBZ2997: Use Non-Null CryptPkcs5Pbkdf2 for RuntimeCryptLib.inf

    @makubacki
    Matthew Carlson authored and makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    446be07 View commit details
    Browse the repository at this point in the history

  6. CryptoPkg: Add host-based unit testing

    @makubacki
    Bret Barkelew authored and makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    27f8a69 View commit details
    Browse the repository at this point in the history

  7. NEEDTCBZ: Fix memory free bug in HmacTest 

    Test is currently using FreePool() when it should use HmacSha256Free()
    @kenlautner @makubacki
    kenlautner authored and makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2fa1d93 View commit details
    Browse the repository at this point in the history

  8. [TCBZ3925] Correct the implementation of Pkcs7Sign 

    The documentation says "DER formatted", but the code was expecting
it to be a pre-processed X509 structure. Add the additional
processing.
    @makubacki
    Bret Barkelew authored and makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    363a8f6 View commit details
    Browse the repository at this point in the history

  9. CryptoPkg: CodeQL Fixes 

    Resolves CodeQL issues in the package.

Co-authored-by: Aaron Pop <[email protected]>
Co-authored-by: Kun Qin <[email protected]>
Co-authored-by: Taylor Beebe <[email protected]>
Co-authored-by: Doug Flick <[email protected]>
Co-authored-by: Ken Lautner <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>
    @makubacki @apop5
    @kuqin12 @TaylorBeebe @Flickdm @kenlautner
    6 people committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8e199ac View commit details
    Browse the repository at this point in the history

  10. Transition to Latest Shared Crypto 

    Updates to the code to match the latest Shared Crypto code in the
release/202311 branch using the 2023.11.3 binary.

For Shared Crypto details and platform integration information,
review https://github.com/microsoft/mu_crypto_release.

Other notable changes include:

- Reconfigures OpensslLib to add elliptic curve chipher algorithms.
- Fixes a memory fre bug in the HmacTest
  - Test is currently using FreePool() when it should use HmacSha256Free()
- Adds SHA384 and SHA512 to the STANDARD flavor of the crypto binary

Co-authored-by: Mike Turner <[email protected]>
Co-authored-by: Bret Barkelew <[email protected]>
Co-authored-by: Kenneth Lautner <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>
    @makubacki @mikeytdisco @kenlautner
    4 people committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dce31bc View commit details
    Browse the repository at this point in the history

  11. NetworkPkg: DSC changes for Shared Crypto 

    Updates the CryptoPkg library instances used after the Shared Crypto
changes in CryptoPkg.

Signed-off-by: Michael Kubacki <[email protected]>
    @makubacki
    makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    76b368d View commit details
    Browse the repository at this point in the history

  12. UefiCpuPkg: DSC changes for Shared Crypto 

    Updates the UefiCpuPkg library instances used after the Shared Crypto
changes in CryptoPkg.

Signed-off-by: Michael Kubacki <[email protected]>
    @makubacki
    makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c6dad17 View commit details
    Browse the repository at this point in the history

  13. Revert "TEMP: Drop CryptoPkg from pipelines builds (until Shared Cryp… 

    …to is added)"

This reverts commit now that CryptoPkg is buildable and in its final
state for 2405.

Signed-off-by: Michael Kubacki <[email protected]>
    @makubacki
    makubacki committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    620c065 View commit details
    Browse the repository at this point in the history