[202405][REBASE&FF] Apply Project Mu BaseTools Changes #1004
+282
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
Javagedes
force-pushed
the
BaseTools-Mu
branch
3 times, most recently
from
b2743fb
to
a12049a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1004 +/- ##
=================================================
Coverage ? 43.42%
=================================================
Files ? 180
Lines ? 25101
Branches ? 6016
=================================================
Hits ? 10901
Misses ? 14135
Partials ? 65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Javagedes
changed the title
os-d
approved these changes
Jul 1, 2024
Javagedes
force-pushed
the
BaseTools-Mu
branch
3 times, most recently
from
3d3ca53
to
955df67
Compare
makubacki
reviewed
Jul 1, 2024
makubacki
reviewed
Jul 1, 2024
makubacki
reviewed
Jul 1, 2024
makubacki
reviewed
Jul 1, 2024
Javagedes
force-pushed
the
BaseTools-Mu
branch
2 times, most recently
from
7497474
to
b162449
Compare
makubacki
approved these changes
Jul 1, 2024
Javagedes
force-pushed
the
BaseTools-Mu
branch
4 times, most recently
from
314b3da
to
fd74d4a
Compare
Javagedes
force-pushed
the
BaseTools-Mu
branch
3 times, most recently
from
e208c24
to
367e16c
Compare
Applies Project Mu changes to the tools_def.template file as noted in the version update.
When including one ASL file in another, add a header / footer to the included file to easily tell where the included file starts and ends. Signed-off-by: Joey Vagedes <[email protected]>
Update MdePkg.dsc to use VsIntrinsicLib when building IA32 components with VS2022 Build Tools. Signed-off-by: Bret Barkelew <[email protected]>
Currently, the build flags located in the respfilelist.txt file (if it exists) are only logged if the command fails,. Thus, The typical log message for a build command that exceeds 4096 characters is the command itself, followed by the flag pointing at the respfilelist.txt. This makes a review of the build log harder than it needs to be. This commit changes the logic such that the build flags are always logged, making it easier to review the build logs, rather than needing to navigate to the respfilelist.txt file. Signed-off-by: Joey Vagedes <[email protected]>
Performs a check that will verify that the library instance implements the library specified in the dsc by ensuring a LIBRARY_CLASS definition exists in the INF [Defines] section and the value matches the library it says it is implementing. That is to say, for the following example: `TestLib|Path/To/BaseTestLib.inf`, that BaseTestLib.inf has `LIBRARY_CLASS = TestLib` defined in the [Defines] section. Signed-off-by: Joey Vagedes <[email protected]>
Update retrieval of private guids, protocols, or ppis from a package's declaration file to use the original path of the module's INF file rather than the current path. When building the same module multiple times in the same INF (by override the define's FILE_GUID), a temporary instance of the module is generated outside the package, causing the retrieval of private values to fail as the check to access private values is done by verifying the module to build, is inside the package. Signed-off-by: Joey Vagedes <[email protected]> Cc: Rebecca Cran <[email protected]> Cc: Liming Gao <[email protected]> Cc: Bob Feng <[email protected]> Cc: Yuwei Chen <[email protected]>
The xdrlib dependency was removed in commit 5cadb8c but the actual import of the module was not removed. This commit removes the import of xdrlib and sorts the imports. Signed-off-by: Joey Vagedes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies Project Mu Changes to BaseTools. Some commits are being upstreamed to edk2.
Includes:
e0afbf0
6335354
a18705c
ad47ec9
5c597f5
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
CI Passes
Integration Instructions
N/A