[Rebase&&FF][Release/202405]NetworkPkg: Add exception for surprise disconnect for PxeBcBoot #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
reviewed
Jul 22, 2024
os-d
approved these changes
Jul 22, 2024
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/Pxe-boot-fix
branch
from
53c88fb
to
bd734b9
Compare
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/Pxe-boot-fix
branch
from
bd734b9
to
2ddaff7
Compare
makubacki
approved these changes
Jul 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1056 +/- ##
================================================
Coverage ? 0.35%
================================================
Files ? 165
Lines ? 70731
Branches ? 1754
================================================
Hits ? 254
Misses ? 70373
Partials ? 104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Network stack fails when USB nic is removed after initialization. This change marks it removed but doesn't clean up memory allocations so that other code holding onto and using that memory doesn't cause an exception. This change in particular corrects this situation during PxeBoot.
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/Pxe-boot-fix
branch
from
2ddaff7
to
c97d009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split off from 0549e53
When upstreaming this can be merged into #1036
How This Was Tested
Release/2023011
Integration Instructions
N/A